Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkBook Usage Report missing fields for analytic rules due to using old preview API #10239

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

v-muuppugund
Copy link
Contributor

Required items, please complete

Change(s):

  • Workbook usage api version updated and added fields description and severity

Reason for Change(s):

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • Yes
    image

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@v-muuppugund v-muuppugund requested review from a team as code owners April 3, 2024 12:30
@v-sudkharat v-sudkharat added the Workbook Workbook specialty review needed label Apr 3, 2024
@v-sudkharat v-sudkharat self-assigned this Apr 3, 2024
Copy link
Contributor

@v-sudkharat v-sudkharat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@v-dvedak v-dvedak merged commit 4d48081 into master Apr 4, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Workbook Workbook specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workbook - WorkBook Usage Report missing fields for analytic rules due to using old preview API
3 participants