Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prancer Solution #8664

Merged
merged 81 commits into from
Nov 1, 2023
Merged

Prancer Solution #8664

merged 81 commits into from
Nov 1, 2023

Conversation

Phenox11
Copy link
Contributor

@Phenox11 Phenox11 commented Jul 29, 2023

Required items, please complete

Change(s):

  • Add Analytics rule, workbook, logo, and hunting query

Reason for Change(s):

  • New Solution

Testing Completed:

  • Need Help

Checked that the validations are passing and have addressed any issues that are present:

  • Need Help

@Phenox11 Phenox11 requested review from a team as code owners July 29, 2023 08:58
Phenox11 added 4 commits July 29, 2023 10:36
replace style to fill in the logo file
- Add Sample Data

- Fix logo to properly display image

- remove resource reference from workbook
@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Jul 31, 2023
@v-prasadboke
Copy link
Contributor

Hello @Phenox1, Thank you for raising this PR. This PR is assigned to me and will get Investigated by me.
You can expect an update till 02 Aug 2023.

@Phenox11
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Prancer"

@Phenox11
Copy link
Contributor Author

The KQL error says that it doesn't know what the "Prancer_CL" table is. That is a custom table that we load into the tenant from our platform after a scan is run. What do we need to do in order to fix that error?

@v-prasadboke
Copy link
Contributor

Hello @Phenox11, Checking the error. I'll Update you as soon as possible about the issue.

@farchide
Copy link

farchide commented Aug 1, 2023

@v-prasadboke Thank you for your help here. Please let us know what would be the reason pipelines failed. It is not clear from the log.

@v-prasadboke
Copy link
Contributor

Hello @Phenox11 Please work on the requested changes above.
I've resolved the KQL validation for connector id's and tactics please resolve for missing custom table
Thanks.

@v-prasadboke
Copy link
Contributor

Hello @Phenox11, Waiting for your response on the above requested changes.

@v-prasadboke
Copy link
Contributor

Hello @Phenox11, I've repackaged the solution. Please take a look at the committed changes.

@v-prasadboke
Copy link
Contributor

Hello @Phenox11, I've resolved the validation error but I've a query about the analytic rule.
Can we connect at 9:00 PM PDT on 26 October, 2023.
Thanks.

@v-prasadboke
Copy link
Contributor

v-prasadboke commented Oct 27, 2023

Hello @Phenox11, I've committed some changes. Please take a look at it. Some changes are needed.

  1. PAC hunting query is missing with Name and Description. Please add it.

  2. Data connector has short description please add a few more lines
    image

  3. Please add configuration steps as well.

image
  1. Solution Description is short, Please add a few more lines.
image
  1. I'm working on Data Connector right now, The Data Connector doesn't gets listed in the data connector blade after accessing it from the Solution. Will update you about it till 01 November, 2023.

This is the only thing left, other than this everything looks good.

@v-prasadboke
Copy link
Contributor

Hello @Phenox11, Data connector is fixed. Please work on the above requested changes.
Thanks.

@v-prasadboke
Copy link
Contributor

image
Hello @Phenox11 This Solution Description is too short please add a few more lines to it.
Thanks.

@v-atulyadav v-atulyadav merged commit c0add4c into Azure:master Nov 1, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants