-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASIM Process Event schema parser with its sample and test data for SentinelOne #8669
ASIM Process Event schema parser with its sample and test data for SentinelOne #8669
Conversation
Hello @jayeshprajapaticrest, thank you for raising Pull Request with us! We will review it internally and get back to you by shortly. |
ETA: for review by 18th Aug |
Parsers/ASimProcessEvent/Parsers/ASimProcessCreateSentinelOne.yaml
Outdated
Show resolved
Hide resolved
Parsers/ASimProcessEvent/Parsers/ASimProcessCreateSentinelOne.yaml
Outdated
Show resolved
Hide resolved
Parsers/ASimProcessEvent/test/SentinelOne_ASimProcessCreate_SchemaTest.csv
Show resolved
Hide resolved
Parsers/ASimProcessEvent/Parsers/ASimProcessCreateSentinelOne.yaml
Outdated
Show resolved
Hide resolved
Parsers/ASimProcessEvent/Parsers/ASimProcessCreateSentinelOne.yaml
Outdated
Show resolved
Hide resolved
Parsers/ASimProcessEvent/test/SentinelOne_ASimProcessCreate_SchemaTest.csv
Outdated
Show resolved
Hide resolved
Parsers/ASimProcessEvent/test/SentinelOne_ASimProcessCreate_DataTest.csv
Outdated
Show resolved
Hide resolved
Hi @jayeshprajapaticrest, can you please make the above suggested changes? |
Hi @jayeshprajapaticrest, please make the above suggested changes. |
Hi @jayeshprajapaticrest, can you please make the suggested changes ? |
…updated parameter name in vimProcessSentinelOne as per unifying parser.
Hi @jayeshprajapaticrest, can you please make the suggested changes ? |
Suggested changes are made in commit 868ebb8 and unifying parser related changes are done in commit e94a8d9 |
Hi @jayeshprajapaticrest, |
@v-atulyadav Two validation error gets resolved. And the currently getting error is not because of our code implementation. As I check its in the other ASIM parser added in the unifying parser file. |
Parsers/ASimProcessEvent/Parsers/ASimProcessCreateSentinelOne.yaml
Outdated
Show resolved
Hide resolved
…ent Vender in tester file and updated sample data as per change.
@vakohl we have mapped the inspection fields below in the ProcessCreate parser, which we found from SentinelOne Alerts logs. |
@v-atulyadav can you check the validation error? |
@jayeshprajapaticrest can you pull the latest files from github. there might be some changes done recently for the process union parsers files. See if this resolves the error |
Hi @vakohl @jayeshprajapaticrest, |
@vakohl @v-atulyadav I also merged latest from master to the PR but it gives error |
Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: