Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXlogDNSLogs #8722

Closed
wants to merge 1 commit into from
Closed

NXlogDNSLogs #8722

wants to merge 1 commit into from

Conversation

v-rbajaj
Copy link
Contributor

@v-rbajaj v-rbajaj commented Aug 4, 2023

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@v-rbajaj v-rbajaj added Parser Parser specialty review needed Solution Solution specialty review needed labels Aug 4, 2023
@v-rbajaj v-rbajaj requested a review from a team as a code owner August 4, 2023 13:57
@v-rbajaj v-rbajaj requested review from a team as code owners August 4, 2023 13:57
@v-rbajaj v-rbajaj marked this pull request as draft August 4, 2023 13:58
@ghost ghost mentioned this pull request Aug 4, 2023
@ghost
Copy link

ghost commented Aug 4, 2023

As discussed, the parser can be purged from the solution altogether. Now that ASimDnsMicrosoftNXLog is by default available, we could use that instead of the one included in the solution.
I am currently working with @vakohl to update the "official" ASimDnsMicrosoftNXLog parser.

@ghost
Copy link

ghost commented Sep 6, 2023

@v-rbajaj In the other thread, #8516 is moving along nicely. If things go well, the changes to the parser(s) will be merged to master, and thus, having this (parser) function added in this PR will not necessary. Do you have any ETA for this, so that we can finally close off #8154 ?

@v-rbajaj v-rbajaj closed this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content-Package P0 Parser Parser specialty review needed Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants