Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commvault Integration with Microsoft Azure Sentinel - V.1.0 #8915

Merged
merged 4 commits into from
Sep 5, 2023

Conversation

Cv-securityIQ
Copy link
Contributor

@Cv-securityIQ Cv-securityIQ commented Aug 30, 2023

Change(s):

  • Created the Commvault Integration Solution that features the following:

    • Runbooks: Three of which are use cases for making API calls to Commvault/Metallic, and one for cycling access tokens
    • Analytic Rules: These query for manually created Sentinel Incidents with specific names and descriptions
    • A detailed Readme file that walks the user through creating the remainder of the integration assets through the GUI

    Reason for Change(s):

    • Initial integration PR.

    Version Updated:

    • Yes
    • Initial pull request.

    Testing Completed:

    • Yes

    Checked that the validations are passing and have addressed any issues that are present:

    • Yes

@Cv-securityIQ Cv-securityIQ requested review from a team as code owners August 30, 2023 19:40
@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Aug 31, 2023
@@ -0,0 +1,15 @@
{
"publisherId": "azuresentinel",
Copy link
Contributor

@v-rbajaj v-rbajaj Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the publisherID to "CommvaultSecurityIQ", then repackage the solution.

}
},
"variables": {
"location": "[[resourceGroup().location]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the "location" to this value "[parameters('workspace-location')]"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made the required changes and pushed them to the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SolutionValidations is failing, can you please take a look?

@@ -0,0 +1,15 @@
{
"publisherId": "CommvaultSecurityIQ",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be in lowercase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the changes and pushed it to the PR, all the validations are passing now, Thanks!

Copy link
Contributor

@v-rbajaj v-rbajaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@v-dvedak v-dvedak merged commit 77ac8d2 into Azure:master Sep 5, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants