Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azurekid - Bugfix DHCP Schema Duration field (ASIM) #8955

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

azurekid
Copy link
Contributor

@azurekid azurekid commented Sep 6, 2023

Required items, please complete

Change(s):

  • ASimTester.csv

Reason for Change(s):

  • The column Duration in the DHCP schema is incorrect.
    The field Duration should be of type int because it an alias for NetworkDuration which also
    has the int type

Version Updated:

  • N/A

Testing Completed:

  • Validated that the CSV format is still valid

Checked that the validations are passing and have addressed any issues that are present:

  • Validated against the ASimSchemaTester function

@azurekid azurekid requested review from a team as code owners September 6, 2023 09:44
@azurekid azurekid changed the title [ASIM] Bugfix DHCP Schema Duration field Azurekid - Bugfix DHCP Schema Duration field (ASIM) Sep 6, 2023
@v-atulyadav v-atulyadav merged commit 9515285 into Azure:master Sep 6, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants