Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpHost LogicalType Fix ASimTester.csv #9003

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

Detectioneer
Copy link
Contributor

Required items, please complete

Change(s):

  • Removed the hostname LogicalType at httpHost (websession)

Reason for Change(s):

Version Updated:

  • No

Testing Completed:

  • No

Checked that the validations are passing and have addressed any issues that are present:

  • NA

@Detectioneer Detectioneer requested review from a team as code owners September 13, 2023 13:24
@v-atulyadav v-atulyadav self-assigned this Sep 14, 2023
@vakohl
Copy link
Contributor

vakohl commented Sep 14, 2023

@Detectioneer the logical type for httpHost is Hostname, so in ASIMtester.csv its correct. I'll have it corrected in Docs

@v-atulyadav
Copy link
Contributor

Thanks @vakohl for clarifying, @Detectioner I hope the change you have proposed is clarified so we can close this case.

@Detectioneer
Copy link
Contributor Author

Hi @vakohl, Thanks for the clarification!

I understood the HttpHost field is typically based on the HTTP Host Header
According to the mozilla documentation linked this field can contain a FQDN for the server, example: developer.mozilla.org
(https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Host)

However, developer.mozilla.org is not a valid hostname according to the Asim Datatester.
It tests against the regex: let Hostname_regex = @'^[a-zA-Z0-9-]{1,61}$';\r\n
Which doesn't seem to allow for periods in the hostname. (https://github.com/Azure/Azure-Sentinel/blob/master/ASIM/dev/ASimTester/ASimDataTester.json)

How should I proceed with this issue ?

@vakohl
Copy link
Contributor

vakohl commented Sep 18, 2023

Hi @vakohl, Thanks for the clarification!

I understood the HttpHost field is typically based on the HTTP Host Header According to the mozilla documentation linked this field can contain a FQDN for the server, example: developer.mozilla.org (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Host)

However, developer.mozilla.org is not a valid hostname according to the Asim Datatester. It tests against the regex: let Hostname_regex = @'^[a-zA-Z0-9-]{1,61}$';\r\n Which doesn't seem to allow for periods in the hostname. (https://github.com/Azure/Azure-Sentinel/blob/master/ASIM/dev/ASimTester/ASimDataTester.json)

How should I proceed with this issue ?

Got it. Make sense. Thanks for sharing this example. @Detectioneer

@v-atulyadav v-atulyadav merged commit 91d9fab into Azure:master Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants