Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google workspace timeout issue #9038

Merged
merged 19 commits into from
Oct 17, 2023
Merged

Google workspace timeout issue #9038

merged 19 commits into from
Oct 17, 2023

Conversation

v-sabiraj
Copy link
Contributor

@v-sabiraj v-sabiraj commented Sep 19, 2023 •
edited by v-mchatla
Loading

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

image

@v-sabiraj v-sabiraj requested review from a team as code owners September 19, 2023 09:49
@v-sabiraj v-sabiraj added the Function Function label Sep 19, 2023
@v-sabiraj v-sabiraj marked this pull request as draft September 22, 2023 10:20
@v-mchatla
Copy link
Contributor

Hi
Still working on further changes.
thanks

v-muuppugund
v-muuppugund reviewed Sep 22, 2023
View reviewed changes
...ons/GoogleWorkspaceReports/Data Connectors/GWorkspaceReportsAPISentinelConnector/__init__.py Show resolved Hide resolved
...ons/GoogleWorkspaceReports/Data Connectors/GWorkspaceReportsAPISentinelConnector/__init__.py Outdated Show resolved Hide resolved
...ons/GoogleWorkspaceReports/Data Connectors/GWorkspaceReportsAPISentinelConnector/__init__.py Outdated Show resolved Hide resolved
...ons/GoogleWorkspaceReports/Data Connectors/GWorkspaceReportsAPISentinelConnector/__init__.py Show resolved Hide resolved
...ons/GoogleWorkspaceReports/Data Connectors/GWorkspaceReportsAPISentinelConnector/__init__.py Show resolved Hide resolved
...ons/GoogleWorkspaceReports/Data Connectors/GWorkspaceReportsAPISentinelConnector/__init__.py Show resolved Hide resolved
...ons/GoogleWorkspaceReports/Data Connectors/GWorkspaceReportsAPISentinelConnector/__init__.py Show resolved Hide resolved
...ons/GoogleWorkspaceReports/Data Connectors/GWorkspaceReportsAPISentinelConnector/__init__.py Show resolved Hide resolved
v-muuppugund
v-muuppugund reviewed Sep 22, 2023
View reviewed changes
Copy link
Contributor

@v-muuppugund v-muuppugund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach test cases executed if any for all the scenarios

@v-mchatla v-mchatla marked this pull request as ready for review October 11, 2023 07:22
@v-mchatla
Copy link
Contributor

Hi @v-muuppugund
Author has confirmed that the code is working as expected, after restarting the function app.
image

image

Thanks

@v-mchatla
Copy link
Contributor

Hi Still working on further changes. thanks

Done with all the changes and get it verified by customer.

@v-mchatla
Copy link
Contributor

Please attach test cases executed if any for all the scenarios

We have tested the scenarios but don't have test plan to attach.

v-muuppugund
v-muuppugund approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@v-muuppugund v-muuppugund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with following suggestions
1.Retry count can be moved to function app configuration.
2.Documentation can be added for the newly changes added

v-muuppugund
v-muuppugund reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@v-muuppugund v-muuppugund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge from master

@v-muuppugund v-muuppugund self-requested a review October 17, 2023 06:22
v-muuppugund
v-muuppugund approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@v-muuppugund v-muuppugund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with below suggestions

  • Retry pattern count at function app configuration
  • Documentation for the new changes added

@v-atulyadav v-atulyadav merged commit e40df6b into master Oct 17, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-mchatla v-mchatla v-mchatla left review comments

@v-muuppugund v-muuppugund v-muuppugund approved these changes

@v-atulyadav v-atulyadav v-atulyadav approved these changes

Assignees

@v-mchatla v-mchatla

Labels
Content-Package Function Function
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@v-sabiraj @v-mchatla @v-atulyadav @v-muuppugund @web-flow