Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution/grey noise1.1 #9070

Merged
merged 88 commits into from
Oct 11, 2023
Merged

Conversation

punkrokk
Copy link
Contributor

@punkrokk punkrokk commented Sep 21, 2023

@v-prasadboke Continued from #8931

@punkrokk
Copy link
Contributor Author

@v-prasadboke Once you tell me everything is good, then I'll update the function zip file to master.

@v-prasadboke
Copy link
Contributor

Ok Thanks.

@v-prasadboke
Copy link
Contributor

Hello @punkrokk, manual instructions for deploying function app is missing from Data connector. Is it ok?
If not please follow this azure deploy on for manual deployment instructions of function app. [ Line no 109 ]
https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/Bitglass/Data%20Connectors/Bitglass_API_FunctionApp.json

@punkrokk
Copy link
Contributor Author

I think we can add manual deployment in v3.1, if that's ok

I removed the python packages.

@punkrokk
Copy link
Contributor Author

@v-prasadboke If we are good I'll update the function URL

@v-prasadboke
Copy link
Contributor

v-prasadboke commented Oct 5, 2023

Please repackage the solution after making these changes.

@punkrokk
Copy link
Contributor Author

punkrokk commented Oct 5, 2023

@v-prasadboke all set and conflicts resolved.

@v-prasadboke
Copy link
Contributor

Hello @punkrokk, Can you please provide write access to your branch/repo so that I can personally commit the required changes to this solution and get this PR closed as soon as possible.

@punkrokk
Copy link
Contributor Author

punkrokk commented Oct 9, 2023

Hello @punkrokk, Can you please provide write access to your branch/repo so that I can personally commit the required changes to this solution and get this PR closed as soon as possible.

Gave you write access.

@v-atulyadav v-atulyadav merged commit 188b6f4 into Azure:master Oct 11, 2023
31 checks passed
@manishkumar1991
Copy link
Contributor

manishkumar1991 commented Jan 31, 2024

@punkrokk We are seeing one vulnerability in your branch, Can you please delete the branch : BlueCycleOps:solution/GreyNoise1-1
, As We can see that PR has been merged already . so if you no longer need this branch then please delete or consider rotating your keys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants