Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiz solution fix workbook #9109

Merged
merged 14 commits into from
Oct 5, 2023

Conversation

yanivblumWiz
Copy link
Contributor

@yanivblumWiz yanivblumWiz commented Sep 27, 2023

Required items, please complete

Change(s):

  • updated workbook in the main template file

Reason for Change(s):

  • queries failed

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@yanivblumWiz yanivblumWiz requested review from a team as code owners September 27, 2023 11:40
@v-atulyadav v-atulyadav added the Solution Solution specialty review needed label Sep 27, 2023
@v-prasadboke
Copy link
Contributor

v-prasadboke commented Sep 28, 2023

Hello @yanivblumWiz, Does the query from maintemplate matches with the query mentioned in actual workbook.
Thanks.

@yanivblumWiz
Copy link
Contributor Author

yanivblumWiz commented Sep 28, 2023

Hello @yanivblumWiz, Does the query from maintemplate matches with the query mentioned in actual workbook. Thanks.
@v-prasadboke
Yes, I just added spaces because the queries were broke the way it was before, without spacings

@v-prasadboke
Copy link
Contributor

Hello @yanivblumWiz, Workbook metadata is missing from the workbookmetadata files.
Also can you please share your mail id so we connect personally and try to get this Merged.
Thanks

@yanivblumWiz
Copy link
Contributor Author

Hello @yanivblumWiz, Workbook metadata is missing from the workbookmetadata files. Also can you please share your mail id so we connect personally and try to get this Merged. Thanks

hi @v-prasadboke, can you please elaborate on what are the workbookmetadata files? I never heard about it so far or seen it. Can you please share some examples?
Also, my email is yaniv.blum@wiz.io feel free to email me as well :)

@v-prasadboke
Copy link
Contributor

Hello @yanivblumWiz, Please visit the link mentioned below and for reference you can have look at any of metadata available in the workbook metadata file.
Thanks.
https://github.com/Azure/Azure-Sentinel/blob/master/Workbooks/WorkbooksMetadata.json

@yanivblumWiz yanivblumWiz requested a review from a team as a code owner September 28, 2023 14:43
@yanivblumWiz
Copy link
Contributor Author

Hello @yanivblumWiz, Please visit the link mentioned below and for reference you can have look at any of metadata available in the workbook metadata file. Thanks. https://github.com/Azure/Azure-Sentinel/blob/master/Workbooks/WorkbooksMetadata.json

@v-prasadboke
Done, please let me know if I need to do something else :)

@v-prasadboke
Copy link
Contributor

Hello @yanivblumWiz, Thank you for committing the changes.

@v-prasadboke v-prasadboke force-pushed the Wiz_solution_fix_workbook branch from 0bc23f4 to 04486ed Compare September 29, 2023 06:27
@v-prasadboke
Copy link
Contributor

Hello @yanivblumWiz sorry for the inconvenience. I pushed master branch in your branch in this scenario the commit for Workbook metadata and images were lost.
Can you please add them again.

@yanivblumWiz
Copy link
Contributor Author

Hello @yanivblumWiz sorry for the inconvenience. I pushed master branch in your branch in this scenario the commit for Workbook metadata and images were lost. Can you please add them again.

@v-prasadboke
I think now it's okay again, let me know how it goes

@v-prasadboke
Copy link
Contributor

Thank you @yanivblumWiz, Will update you till 04 October, 2023.

@v-atulyadav
Copy link
Contributor

Hi @yanivblumWiz,
We apologize for the delay, but due to lack of availability, we will update you on this by 06 Oct 2023. Thanks

@yanivblumWiz
Copy link
Contributor Author

Hi @yanivblumWiz, We apologize for the delay, but due to lack of availability, we will update you on this by 06 Oct 2023. Thanks

@v-atulyadav, thanks for the update.
If you guys could please make an effort and merge this before, we would highly appreciate it as we have many customers waiting for this to be updated.

@v-prasadboke
Copy link
Contributor

Hello @yanivblumWiz, I corrected the support tier in maintemplate but dont have push access to this branch. So ill get this PR merged and raise another PR for latest zip file and release note.md

@v-atulyadav v-atulyadav merged commit 51b69c9 into Azure:master Oct 5, 2023
29 checks passed
@yanivblumWiz yanivblumWiz deleted the Wiz_solution_fix_workbook branch October 5, 2023 10:09
@yanivblumWiz
Copy link
Contributor Author

@v-atulyadav Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants