Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feedly solution] fix issues #9110

Merged
merged 1 commit into from
Sep 28, 2023
Merged

[feedly solution] fix issues #9110

merged 1 commit into from
Sep 28, 2023

Conversation

Mathieu4141
Copy link
Contributor

Change(s):

  • Fix publisher id
  • Fix Microsoft Sentinel branding

Reason for Change(s):

  • Validation failed for publishing the solution:
Screenshot 2023-09-27 at 2 33 51 PM

Version Updated:

  • N/A

Testing Completed:

  • N/A

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@Mathieu4141 Mathieu4141 requested review from a team as code owners September 27, 2023 12:44
@v-prasadboke v-prasadboke added the Solution Solution specialty review needed label Sep 28, 2023
@v-dvedak
Copy link
Contributor

v-dvedak commented Sep 28, 2023 •
edited
Loading

Hi @Mathieu4141, Please address below comments:

  • I see the files inside package and outside are different. Can you please check and correct?

  • ARM-TTK is failing for keyvaultApiId. Please refer below screenshot.
    image

  • Also, can you please resolve the branch conflicts?

@Mathieu4141
Copy link
Contributor Author

Thanks for the review @v-dvedak !

  • I see the files inside package and outside are different. Can you please check and correct?

I'm not sure I understand this, could you clarify?

  • ARM-TTK is failing for keyvaultApiId. Please refer below screenshot.
    image

I don't understand the error, could you explain?

  • Also, can you please resolve the branch conflicts?

Sorry, done!

@v-dvedak v-dvedak merged commit fd66f23 into Azure:master Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-dvedak v-dvedak v-dvedak approved these changes

Assignees

@v-dvedak v-dvedak

Labels
Solution Solution specialty review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mathieu4141 @v-dvedak @v-prasadboke