Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addition of new playbook to o365 solution #9121

Merged
merged 5 commits into from
Sep 29, 2023
Merged

addition of new playbook to o365 solution #9121

merged 5 commits into from
Sep 29, 2023

Conversation

manishkumar1991
Copy link
Contributor

Required items, please complete

Change(s):

  • Addition of new playbook to delete malicious email forwarding rule

Reason for Change(s):

  • Customer Requested

Version Updated:

  • N/A

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@manishkumar1991 manishkumar1991 requested review from a team as code owners September 29, 2023 08:10
@v-atulyadav v-atulyadav added Playbook Playbook specialty review needed Solution Solution specialty review needed labels Sep 29, 2023
rahul0216
rahul0216 reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@rahul0216 rahul0216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment succeeded. Logic looks good.
Couple of spelling mistakes. Please check the inline comments.

...or Office 365/Playbooks/O365DefenderPlaybooks/o365-DeleteMaliciousInboxRule/azuredeploy.json Outdated
"contentVersion": "1.0.0.0",
"metadata": {
"title": "O365 - Delete All Malicious Inbox Rule",
"description": "This Playbook Provides the automation on deleting all the suspicious/malicious Inbox Rules from Porvided Mailbox",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect spelling 'Porvided'. Also 'Provides' p should be small. Please check this json for any grammar of spelling mistakes.

...ender for Office 365/Playbooks/O365DefenderPlaybooks/o365-DeleteMaliciousInboxRule/readme.md Outdated
1. Select the Keyvault resource where you have stored the secret
2. Click on Access policies Blade
3. Click on Create
4. Under Secret permissions columun , Select Get , List from "Secret Management Operations"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct spelling 'columun'.

rahul0216
rahul0216 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@rahul0216 rahul0216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@v-atulyadav v-atulyadav merged commit ce3b29f into master Sep 29, 2023
30 checks passed
@v-atulyadav v-atulyadav mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-atulyadav v-atulyadav v-atulyadav approved these changes

@rahul0216 rahul0216 rahul0216 approved these changes

Assignees

@v-rbajaj v-rbajaj

Labels
Content-Package Playbook Playbook specialty review needed Solution Solution specialty review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manishkumar1991 @rahul0216 @v-atulyadav @v-rbajaj