Users/gaemslie/8504 #9148

keyoke · 2023-10-04T08:52:05Z

Applies connector updates to resolve #8504, to enable paging behaviour changes implemented by Microsoft Team

….... Only .yaml, .md extensions are allowed under Solution/Parsers folder"

v-sudkharat · 2023-10-04T12:50:21Z

Hi @keyoke, thank you for raising Pull Request with us! You should expect an initial response to your Pull Request from the team within 2 business days. Thanks!

v-sudkharat · 2023-10-09T08:08:31Z

Hi @keyoke, could you please have a look at below comment. Thanks!
#8504 (comment)

v-sudkharat · 2023-10-11T06:43:02Z

Hi @keyoke, hope you are doing well, just want to know should we start to review this PR if no, could you please mark it as Draft PR. Thanks!

keyoke · 2023-10-13T07:38:17Z

@v-sudkharat please review this issue is again resolved on the Microsoft side

v-sudkharat · 2023-10-13T09:13:10Z

Hi @keyoke, thanks for clarify.
As per latest guidelines issued by Microsoft Sentinel, please repackage the solution using "V3 tool". and add "Release Notes" for solution.
Please read this readme file for instructions on using the "V3 tool" and while creating "Release Notes".

V3 Tool Link: - https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V3/README.md
Release Notes Link: - https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/ReleaseNotesGuidance.md

Thanks!

keyoke · 2023-10-16T09:06:58Z

Hi @keyoke, thanks for clarify. As per latest guidelines issued by Microsoft Sentinel, please repackage the solution using "V3 tool". and add "Release Notes" for solution. Please read this readme file for instructions on using the "V3 tool" and while creating "Release Notes".

V3 Tool Link: - https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V3/README.md Release Notes Link: - https://github.com/Azure/Azure-Sentinel/blob/master/Solutions/ReleaseNotesGuidance.md

Thanks!

hi @v-sudkharat I have done as requested. please review

v-sudkharat · 2023-10-16T12:50:17Z

Hi @keyoke, thank you for accommodating the suggested changes! We will review the Pull Request and get back to you by -
20-10-2023.
Meanwhile, please can you add the successfully running/connected screenshot of "Data Connector" in chat.
Thanks!

keyoke · 2023-10-17T10:00:23Z

here you go,

v-sudkharat · 2023-10-17T12:50:38Z

@keyoke, Thanks!

v-sudkharat · 2023-10-19T12:29:44Z

Hi @keyoke, could you please add the ReleaseNotes reference in createUiDefinition.json file and also add some detailed description in below highlighted screenshot.
Sharing the createUiDefinition.json` file in the chat for add ReleaseNotes reference. -createUiDefinition.zip

I see you added the ReleaseNotes reference in Workbook description, please remove it.

We are working on review the other content of solution, meanwhile, we don't have the live environment, so, please share the screenshot of all working playbooks and Data Connectors.

Thanks!

v-sudkharat · 2023-10-23T05:43:37Z

Hi @keyoke, please have a look at above comment. Thanks!

keyoke · 2023-10-23T08:22:41Z

createUiDefinition.zip

hello @v-sudkharat I have made the required changes

screenshots

v-sudkharat · 2023-10-23T09:14:29Z

Hi @keyoke, thanks for committing the changes. I can see you added the release notes reference in different path -

Please refer below screenshot to adding the ReleaseNote reference. -

we don't have the live environment, so, please share the screenshot of all working playbooks. Thanks!

v-sudkharat · 2023-10-23T10:04:17Z

@keyoke, if you don't required, can you please remove the zip which highlighted in Red.
And also revert the change for highlighted in "Yellow".

keyoke · 2023-10-23T10:05:23Z

@keyoke, if you don't required, can you please remove the zip which highlighted in Red. And also revert the change for highlighted in "Yellow".

done

v-sudkharat · 2023-10-23T12:32:12Z

Hi @keyoke, we are facing some issue, while testing the content. Please update the sample data for below tables: -

DynatraceAttacks_CL.json
DynatraceProblems_CL.json 
DynatraceAuditLogs_CL.json
DynatraceSecurityProblems_CL.json

Thanks!

keyoke · 2023-10-23T13:22:24Z

Hi @keyoke, we are facing some issue, while testing the content. Please update the sample data for below tables: -
DynatraceAttacks_CL.json
DynatraceProblems_CL.json 
DynatraceAuditLogs_CL.json
DynatraceSecurityProblems_CL.json 
Thanks!

Hi @v-sudkharat,
What exactly is the issue?
Thanks

v-sudkharat · 2023-10-23T14:32:26Z

Hi @keyoke, we are unable to save the Parser -

keyoke · 2023-10-24T08:53:46Z

Hi @keyoke, we are unable to save the Parser -

against actual data works fine

not sure how you're importing the sample data

v-sudkharat · 2023-10-25T09:06:43Z

Hello @keyoke, these screenshots are ok. As you may know the Analytic rules is parser dependent, to test those we do need to save the parsers. Due to lack of sample data parsers are showing us below result. Can you please provide updated sample data with us.

v-sudkharat · 2023-10-25T09:22:14Z

@keyoke, we updated the createUiDefinition.json for Release Notes, please update below shared file with existing one. Thanks!
createUiDefinition.zip

keyoke · 2023-10-25T15:38:19Z

@keyoke, we updated the createUiDefinition.json for Release Notes, please update below shared file with existing one. Thanks! createUiDefinition.zip

ok that should be done

v-sudkharat · 2023-10-27T10:38:04Z

Hi @keyoke, I see you removed the below highlighted package. please revert the changes for 2.0.0 instead of deleting it.

In CreateUi file the data connector description is common for below highlighted lines. please update it or remove.

v-sudkharat · 2023-10-27T10:46:40Z

@keyoke , please have a look at this comment -#9148 (comment)
Thanks!

keyoke · 2023-10-27T12:28:20Z

Hello @keyoke, these screenshots are ok. As you may know the Analytic rules is parser dependent, to test those we do need to save the parsers. Due to lack of sample data parsers are showing us below result. Can you please provide updated sample data with us.

ok I have added the required sample data

v-sudkharat · 2023-10-30T04:32:34Z

@keyoke, thanks for providing new the sample data with us, you can keep the old one, which is highlighted below.

please have a look at this comment - #9148 (comment)

Also, the 3.0.0 zip contains only 2 files - createUiDefinition.json and mainTemplate.json
Please remove the subfolders inside the zip file.

Thanks!

keyoke · 2023-10-30T09:32:41Z

@keyoke, thanks for providing new the sample data with us, you can keep the old one, which is highlighted below.

please have a look at this comment - #9148 (comment)

Also, the 3.0.0 zip contains only 2 files - createUiDefinition.json and mainTemplate.json Please remove the subfolders inside the zip file.

Thanks!

ok have done this

v-sudkharat · 2023-10-30T09:42:02Z

@keyoke, thanks. please have a look on below comment -

keyoke · 2023-10-30T10:23:27Z

@keyoke, thanks. please have a look on below comment -

ok have reverted

v-sudkharat · 2023-10-30T13:37:50Z

Hi @keyoke, Thanks for making suggested changes.

v-sudkharat

Changes Looks Good.
Adding the Screenshots of Solution Tested Successfully : -

Main template deployment Successful -
Data Connector Page -

Analytic Rule Validated and Created Successfully

Workbook Created Successfully -

CreateUi Looks good (logo is visible) -

All Solution content created successfully.

(Note: Data connector Successfully connected, and playbook successfully deployed screenshot is added in PR itself)

keyoke and others added 5 commits September 13, 2023 16:45

implement changes to fix Azure#8504

3f4a7d8

added package for Azure#8504

5cd0dad

update version

b22326b

update package fixed parser issue

01aac34

Merge branch 'Azure:master' into users/gaemslie/8504

b4f55f2

keyoke requested review from a team as code owners October 4, 2023 08:52

fix pipeline validation issue "Files with disallowed extensions found…

2e028d4

….... Only .yaml, .md extensions are allowed under Solution/Parsers folder"

v-atulyadav assigned v-sudkharat Oct 4, 2023

v-atulyadav added the Solution Solution specialty review needed label Oct 4, 2023

v-sudkharat mentioned this pull request Oct 10, 2023

Dynatrace data connectors paging not working as expected #8504

Closed

switch to 3.0.0 packaging

6ed60c1

updated ui definition

f65b15f

keyoke added 2 commits October 23, 2023 10:43

use Microsoft Sentinel

fc748ac

updated package

94190cb

removed unused parameters

df7a56f

removed old packages

5aae95c

keyoke added 2 commits October 25, 2023 17:32

updated ui definition file

d2f4e5e

updated package

9bb08b0

added sample data

c442962

keyoke added 2 commits October 30, 2023 10:07

updated package

4578792

re-added files

244ae79

updated ui def

ae302ef

keyoke added 2 commits October 30, 2023 11:18

revert removal of 2.0.0.zip

81be2c8

revert to prior commit

bca5604

v-sudkharat approved these changes Oct 30, 2023

View reviewed changes

v-atulyadav approved these changes Oct 30, 2023

View reviewed changes

v-atulyadav merged commit 73cef19 into Azure:master Oct 30, 2023
29 checks passed

v-sudkharat mentioned this pull request Nov 3, 2023

fixed broken dynatrace doc links #9327

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Users/gaemslie/8504 #9148

Users/gaemslie/8504 #9148

keyoke commented Oct 4, 2023

v-sudkharat commented Oct 4, 2023

v-sudkharat commented Oct 9, 2023

v-sudkharat commented Oct 11, 2023

keyoke commented Oct 13, 2023

v-sudkharat commented Oct 13, 2023

keyoke commented Oct 16, 2023

v-sudkharat commented Oct 16, 2023 •

edited

Loading

keyoke commented Oct 17, 2023

v-sudkharat commented Oct 17, 2023

v-sudkharat commented Oct 19, 2023

v-sudkharat commented Oct 23, 2023

keyoke commented Oct 23, 2023 •

edited

Loading

v-sudkharat commented Oct 23, 2023

v-sudkharat commented Oct 23, 2023

keyoke commented Oct 23, 2023

v-sudkharat commented Oct 23, 2023

keyoke commented Oct 23, 2023

v-sudkharat commented Oct 23, 2023

keyoke commented Oct 24, 2023 •

edited

Loading

v-sudkharat commented Oct 25, 2023

v-sudkharat commented Oct 25, 2023

keyoke commented Oct 25, 2023

v-sudkharat commented Oct 27, 2023 •

edited

Loading

v-sudkharat commented Oct 27, 2023

keyoke commented Oct 27, 2023

v-sudkharat commented Oct 30, 2023

keyoke commented Oct 30, 2023

v-sudkharat commented Oct 30, 2023

keyoke commented Oct 30, 2023

v-sudkharat commented Oct 30, 2023

v-sudkharat left a comment

Users/gaemslie/8504 #9148

Users/gaemslie/8504 #9148

Conversation

keyoke commented Oct 4, 2023

v-sudkharat commented Oct 4, 2023

v-sudkharat commented Oct 9, 2023

v-sudkharat commented Oct 11, 2023

keyoke commented Oct 13, 2023

v-sudkharat commented Oct 13, 2023

keyoke commented Oct 16, 2023

v-sudkharat commented Oct 16, 2023 • edited Loading

keyoke commented Oct 17, 2023

v-sudkharat commented Oct 17, 2023

v-sudkharat commented Oct 19, 2023

v-sudkharat commented Oct 23, 2023

keyoke commented Oct 23, 2023 • edited Loading

v-sudkharat commented Oct 23, 2023

v-sudkharat commented Oct 23, 2023

keyoke commented Oct 23, 2023

v-sudkharat commented Oct 23, 2023

keyoke commented Oct 23, 2023

v-sudkharat commented Oct 23, 2023

keyoke commented Oct 24, 2023 • edited Loading

v-sudkharat commented Oct 25, 2023

v-sudkharat commented Oct 25, 2023

keyoke commented Oct 25, 2023

v-sudkharat commented Oct 27, 2023 • edited Loading

v-sudkharat commented Oct 27, 2023

keyoke commented Oct 27, 2023

v-sudkharat commented Oct 30, 2023

keyoke commented Oct 30, 2023

v-sudkharat commented Oct 30, 2023

keyoke commented Oct 30, 2023

v-sudkharat commented Oct 30, 2023

v-sudkharat left a comment

Choose a reason for hiding this comment

v-sudkharat commented Oct 16, 2023 •

edited

Loading

keyoke commented Oct 23, 2023 •

edited

Loading

keyoke commented Oct 24, 2023 •

edited

Loading

v-sudkharat commented Oct 27, 2023 •

edited

Loading