Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repackaging - Okta Single Sign-On (using Azure Functions) #9184

Merged
merged 15 commits into from
Oct 18, 2023
Merged

Repackaging - Okta Single Sign-On (using Azure Functions) #9184

merged 15 commits into from
Oct 18, 2023

Conversation

v-rusraut
Copy link
Contributor

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

@v-rusraut v-rusraut requested review from a team as code owners October 10, 2023 06:54
@v-rusraut v-rusraut added the Solution Solution specialty review needed label Oct 10, 2023
@v-rusraut
Copy link
Contributor Author

/Package

rahul0216
rahul0216 reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@rahul0216 rahul0216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed the description changes. Please have a look at inline comments.

Solutions/Okta Single Sign-On/Hunting Queries/AdminPrivilegeGrant.yaml Show resolved Hide resolved
Solutions/Okta Single Sign-On/Hunting Queries/ImpersonationSession.yaml Show resolved Hide resolved
Solutions/Okta Single Sign-On/Hunting Queries/RareMFAOperation.yaml Show resolved Hide resolved
Solutions/Okta Single Sign-On/Hunting Queries/UserPasswordReset.yaml Show resolved Hide resolved
rahul0216
rahul0216 previously approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@rahul0216 rahul0216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the hunting query description changes. Looks good.
Rest changes need to be verified by relevant SMEs.

@v-atulyadav v-atulyadav merged commit 8d9ebb2 into master Oct 18, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-atulyadav v-atulyadav v-atulyadav approved these changes

@rahul0216 rahul0216 rahul0216 left review comments

Assignees

@v-atulyadav v-atulyadav

Labels
auto-package Content-Package Solution Solution specialty review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-rusraut @rahul0216 @v-atulyadav @web-flow