Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confidence Score to IPEntity files #9191

Closed
wants to merge 6 commits into from
Closed

Confidence Score to IPEntity files #9191

wants to merge 6 commits into from

Conversation

mmelndezlujn
Copy link
Contributor

Required items, please complete

Change(s):

  • Modified all IPEntity files to determine Alert Priority based on Confidence Score
  • Added logic to filter rows where confidence score was less than 51
  • Added alertDetailsOverride to coincide with the Alert Priority

Reason for Change(s):

  • To add the Alert Priority

Version Updated:

  • Yes

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • No

   Required items, please complete

   Change(s):
   - Modified all IPEntity files to determine Alert Priority based on Confidence Score
   - Added logic to filter rows where confidence score was less than 51
   - Added alertDetailsOverride to coincide with the Alert Priority

   Reason for Change(s):
   - To add the Alert Priority

   Version Updated:
   - Yes

   Testing Completed:
   - Yes

   Checked that the validations are passing and have addressed any issues that are present:
   - No
@mmelndezlujn mmelndezlujn requested review from a team as code owners October 10, 2023 16:24
@v-atulyadav v-atulyadav added Analytic Rules Solution Solution specialty review needed labels Oct 11, 2023
@v-prasadboke
Copy link
Contributor

Hello @mmelndezlujn, Thanks for raising this PR.
This PR will be investigated and will update you about the same before 13 October, 2023.
Until then can you please clear the validation fails.

@v-prasadboke
Copy link
Contributor

Hello @mmelndezlujn please repackage the solution and please clear the validation fails.
Instruction on repackaging the solution and using the V3 tool
https://github.com/Azure/Azure-Sentinel/blob/master/Tools/Create-Azure-Sentinel-Solution/V3/README.md

@v-prasadboke
Copy link
Contributor

Hello @mmelndezlujn, Please repackage the solution.

@v-prasadboke
Copy link
Contributor

Hello @mmelndezlujn, Please repackage the solution after committing your final changes.

@v-prasadboke
Copy link
Contributor

Hello @mmelndezlujn, We are waiting for your response.

@v-prasadboke
Copy link
Contributor

Hello @mmelndezlujn, please respond to the above comments.

@v-prasadboke
Copy link
Contributor

Hello @mmelndezlujn please repackage the solution.

@v-prasadboke
Copy link
Contributor

Hello Manuel, Please work on the above requested changes.

@v-prasadboke
Copy link
Contributor

Hello there, @mmelndezlujn. Please notify us if any changes are still pending on your end.

@v-prasadboke
Copy link
Contributor

Hello there, @mmelndezlujn. Could you please respond to the remarks above?

@mmelndezlujn
Copy link
Contributor Author

Hello there, @mmelndezlujn. Please notify us if any changes are still pending on your end.

Hello! I don't think there are any pending changes.

@mmelndezlujn mmelndezlujn reopened this Nov 7, 2023
@v-prasadboke
Copy link
Contributor

Ok Thanks for confirming can you please repackage the solution.

@v-prasadboke
Copy link
Contributor

Hello @mmelndezlujn, can you please work on the requested changes.

@aprakash13
Copy link
Contributor

Task pending on me to review this PR by @mmelndezlujn and help with packaging effort. Would get this addressed by 11/15.

@v-prasadboke
Copy link
Contributor

Thanks, Noted @aprakash13.

@mmelndezlujn mmelndezlujn closed this by deleting the head repository Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytic Rules Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants