Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Zoom data connector to pass Zoom webhook endpoint validation #9201

Merged
merged 8 commits into from
Nov 7, 2023

Conversation

aka0
Copy link

@aka0 aka0 commented Oct 11, 2023

Required items, please complete

Change(s):

  • Implemented data connector response to Zoom's challenge-response check in run.ps1

Reason for Change(s):

Testing Completed:

  • Yes
  • Passed validation and successfully received events

image

Checked that the validations are passing and have addressed any issues that are present:

- Implemented data connector response to Zoom's challenge-response check. Required for new webhooks created after Oct 23, 2022.

Reference: https://developers.zoom.us/docs/api/rest/webhook-reference/#validate-your-webhook-endpoint
@aka0 aka0 requested review from a team as code owners October 11, 2023 23:09
@v-atulyadav v-atulyadav added the Connector Connector specialty review needed label Oct 12, 2023
@v-prasadboke
Copy link
Contributor

v-prasadboke commented Oct 12, 2023

Hello @aka0 Thanks for raising this PR. This PR will be investigated and will update you about the same before 16 October, 2023.
Until then please try to resolve validation errors.

@aka0
Copy link
Author

aka0 commented Oct 13, 2023

Resolved validation error

@v-prasadboke
Copy link
Contributor

Hello @aka0, Thank you for resolving the validations. Will take a look at this and will update you about the same before 19 October, 2023.

@v-prasadboke
Copy link
Contributor

Hello @aka0, Sorry for the convenience due to some priority task didn't got time to check on this.
Will investigate this PR and update you about the same before 23 October, 2023.

@v-prasadboke
Copy link
Contributor

  1. SecretToken should be fetched from parms of function app,please do necessary changes
    Armdeply.json

  2. Need to add details in Readme how to get the secret and add in function app configuration->Steo

3 .Please add null check secret token.
If its null or empty please ask them to add secret token in azuredeploy,json

4 The Zoom Developer Platform is an open platform that allows third-party developers to build applications and integrations upon Zoom’s video-first unified communications platform.
Pay load parameters null check->Zoom side plain token this should be having null check
if its null log and show app
If its not null then only proceed
8.validationPayload null check should happen and its present proceed

@aka0
Copy link
Author

aka0 commented Oct 24, 2023

Can you clarify on point 4?

4 The Zoom Developer Platform is an open platform that allows third-party developers to build applications and integrations upon Zoom’s video-first unified communications platform.
Pay load parameters null check->Zoom side plain token this should be having null check
if its null log and show app
If its not null then only proceed

- Added secret token as a parameter field in deployment
- Revised run.ps1 to check for null
@v-prasadboke
Copy link
Contributor

Add a null check to payload parameter.

@aka0
Copy link
Author

aka0 commented Oct 25, 2023

Add a null check to payload parameter.

That's done.

@v-prasadboke
Copy link
Contributor

Hello @aka0, Thank you for committing the requested changes. We will investigate this and will update you about the same before 31 October, 2023.

@v-prasadboke
Copy link
Contributor

Hello @aka0, Can you please share the latest working/running images of the function app

@aka0
Copy link
Author

aka0 commented Oct 31, 2023

Hello @aka0, Can you please share the latest working/running images of the function app

image

@v-prasadboke
Copy link
Contributor

Hello @aka0, You have added one enviorment variable zoomsecrettoken to the Powershell script. May I know where its fetching the secret token from.

Can we schedule a call for this as per your conveniency. I work in IST time zone. Please do share your email id so we can connect for the same. @v-muuppugund will be in the call too.
Thanks.

@aka0
Copy link
Author

aka0 commented Nov 1, 2023

Hello @aka0, You have added one enviorment variable zoomsecrettoken to the Powershell script. May I know where its fetching the secret token from.

Can we schedule a call for this as per your conveniency. I work in IST time zone. Please do share your email id so we can connect for the same. @v-muuppugund will be in the call too. Thanks.

ZoomSecretToken is a parameter set in azuredeploy.json.

I'll send a teams invite via company account.

@v-prasadboke
Copy link
Contributor

Hello Arthur, Received invitation. Thanks.

@v-prasadboke
Copy link
Contributor

Hello @aka0, As discussed in the call we will get back to you on 06 November, 2023.
Thanks.

Murali Krishna Dev U added 2 commits November 6, 2023 21:26
@aka0
Copy link
Author

aka0 commented Nov 7, 2023

Updated screenshots after deployment using the new arm template (ZoomSecretToken)
Screenshot 2023-11-06 at 8 04 21 PM
Screenshot 2023-11-06 at 8 03 41 PM
Screenshot 2023-11-06 at 8 09 05 PM

Copy link
Contributor

@v-muuppugund v-muuppugund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the changes as per discussion tested on call with Arthur

@v-atulyadav v-atulyadav merged commit 314083b into Azure:master Nov 7, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connector Connector specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants