Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PIMElevationRequestRejected.yaml #9231

Merged
merged 6 commits into from
Oct 19, 2023

Conversation

v-rbajaj
Copy link
Contributor

@v-rbajaj v-rbajaj commented Oct 17, 2023

Required items, please complete

Change(s):

  • updated query change in analytical rule

Reason for Change(s):

  • See guidance below

Version Updated:

  • 3.0.5

Testing Completed:

  • yes
image

@github-actions
Copy link
Contributor

Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

Copy link
Contributor

@rahul0216 rahul0216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@rahul0216 rahul0216 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'where' is missing

@github-actions
Copy link
Contributor

Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

rahul0216
rahul0216 previously approved these changes Oct 17, 2023
v-atulyadav
v-atulyadav previously approved these changes Oct 17, 2023
@v-atulyadav v-atulyadav dismissed their stale review October 17, 2023 11:54

changes required

@github-actions
Copy link
Contributor

Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

@github-actions
Copy link
Contributor

Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

@github-actions
Copy link
Contributor

Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

@v-atulyadav v-atulyadav merged commit 2748130 into master Oct 19, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants