Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating proper mapping of entities in MDE hunting queries #9318

Merged
merged 17 commits into from
Dec 4, 2023

Conversation

manishkumar1991
Copy link
Contributor

Required items, please complete

Change(s):

  • Entities has been mapped

Reason for Change(s):

  • Entities were not mapped earlier

Version Updated:

  • Yes

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

@manishkumar1991 manishkumar1991 requested review from a team as code owners November 1, 2023 09:58
@v-atulyadav v-atulyadav added Solution Solution specialty review needed Hunting Hunting specialty review needed labels Nov 1, 2023
@v-atulyadav v-atulyadav self-assigned this Nov 1, 2023
@vakohl
Copy link
Contributor

vakohl commented Nov 2, 2023

@manishkumar1991 Validation issues are coming. Please have a look.

@v-sudkharat v-sudkharat linked an issue Nov 3, 2023 that may be closed by this pull request
@vakohl
Copy link
Contributor

vakohl commented Nov 6, 2023

@v-atulyadav can you please have a look why validation error is coming. Once we fix the validation, the PR can be approved.

@v-rbajaj
Copy link
Contributor

Hi @vakohl, we have fixed the ARM TTK validation now, I think this PR is good to be approved.

vakohl
vakohl previously approved these changes Nov 16, 2023
@v-atulyadav v-atulyadav merged commit 009386d into master Dec 4, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content-Package Hunting Hunting specialty review needed Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misplaced scheduled rule
5 participants