feat(vscode): Auto regenerate managed api connection keys #4982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mireedmsft
reviewed
Jun 14, 2024
mireedmsft
approved these changes
Jul 5, 2024
|
Is this ready to merge? |
|
unit tests still in progress |
ccastrotrejo
requested changes
Jul 15, 2024
* introducing connectionKeys.ts for auto regenerate keys * removed comment in pickFuncProcess * jwtHelper compatible without atob and local setting file access fixes * add logic for resolving connection ids * added function to format settings before api call * updated jwtHelper and workflow services and their imports, added unit tests and logging * update changes to connection.ts * changed workflow to export functions and enabled duration telemetry * fixed typo in workflow * fixed workflow utility --------- Co-authored-by: Joaquim Malcampo <jmalcampo@microsoft.com>
ccastrotrejo
requested changes
Jul 19, 2024
ccastrotrejo
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This introduces behavior which automatically regenerates managed api connection keys in the local settings file during project load and before flow execution.
What is the current behavior? (You can also link to an open issue here)
Currently, managed api connection keys expire after 7 days of creation. There is no gesture or behavior to renew these connection keys.
What is the new behavior (if this is a feature change)?
The connection keys would be checked during project load and before flow execution and then regenerated if the key is expired or if its within the buffer of expiry. This is automatic and does not alert the customer when these keys are regerated.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No.
Please Include Screenshots or Videos of the intended change:
WIP