Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding UI for NL2F Expression Assistant and Copilot Service Interface #5107

Merged
merged 31 commits into from
Jul 23, 2024

Conversation

maturpi
Copy link
Contributor

@maturpi maturpi commented Jul 11, 2024

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature

  • What is the current behavior? (You can also link to an open issue here)
    N/A

  • What is the new behavior (if this is a feature change)?
    N/A

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Please Include Screenshots or Videos of the intended change:
    nl2fExpressionUIDemo

@hartra344
Copy link
Contributor

please add some tests

Copy link

@LLotme LLotme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gh pr checkout 5107

@maturpi
Copy link
Contributor Author

maturpi commented Jul 23, 2024

please add some tests

Done @hartra344

@hartra344
Copy link
Contributor

@Eric-B-Wu can you review please?

return generateMockResults(query, originalExpression);
}

// To be implemented by LAUX team
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we create a github issue/work item for this

@hartra344 hartra344 enabled auto-merge (squash) July 23, 2024 19:49
@hartra344 hartra344 merged commit 6cef0e1 into Azure:main Jul 23, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants