fix(vscode): Refactor Parameters.json into a separate artifact class when converting to NuGet project #5116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mireedmsft
changed the title
ccastrotrejo
approved these changes
Jul 15, 2024
|
@mireedmsft when you merge it can you update hte commit title to something more descriptive. This goes into the changelog |
mireedmsft
changed the title
Made as specific as I can and still fit into the character limit :) |
rllyy97
pushed a commit
that referenced
this pull request
Jul 16, 2024
…when converting to NuGet project (#5116) fix(vscode) AddParametersToArtifacts
rllyy97
added a commit
that referenced
this pull request
Jul 16, 2024
* fix(vscode): Add Parameters.json in .Net project conversion (#5110) ConnectionParameterization: - add parameters.json to the csproj file when converting to .net (if it's present in the target directory) * fix(vscode): Refactor Parameters.json into a separate artifact class when converting to NuGet project (#5116) fix(vscode) AddParametersToArtifacts --------- Co-authored-by: Michael Reed <60761072+mireedmsft@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fit and Finish: Refactor GetArtifactNamesFromProject to separate the parameters.json file into its own separate artifact class to remove ambiguity with the connections.json file
What is the current behavior? (You can also link to an open issue here)
Strict refactoring, no behavior change
What is the new behavior (if this is a feature change)?
Strict refactoring, no behavior change
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Please Include Screenshots or Videos of the intended change:
Strict refactoring, no behavior change