Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for installing agent in e2e tests #3271

Merged
merged 2 commits into from
Dec 9, 2024
Merged

fix for installing agent in e2e tests #3271

merged 2 commits into from
Dec 9, 2024

Conversation

nagworld9
Copy link
Contributor

Description

Fixing

  1. Existing agent purging the test agent when it's found a regular agent update beacuse we copy the test agent to agent folder before stopping the agent. So moving the copy after stop
  2. Unable to install test agent if version lower than existing agents, so cleaning the existing agents from agent folder.

Issue #

PR information

  • Ensure development PR is based on the develop branch.
  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

narrieta
narrieta reviewed Dec 5, 2024
View reviewed changes
tests_e2e/orchestrator/scripts/install-agent Outdated
agent-service stop

# Rename the previous log to ensure the new log starts with the agent we just installed
mv /var/log/waagent.log /var/log/waagent."$(date --iso-8601=seconds)".log

echo "Cleaning up the existing agents"
rm -rf /var/lib/waagent/WALinuxAgent-*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you do verbose so that the log captures the agents we removed? thanks

Copy link
Contributor Author

@nagworld9 nagworld9 Dec 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, updated

@nagworld9 nagworld9 merged commit 23be951 into Azure:develop Dec 9, 2024
9 of 11 checks passed
@nagworld9 nagworld9 deleted the installagent-fix branch December 9, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddieford maddieford maddieford approved these changes

@narrieta narrieta narrieta approved these changes

@ZhidongPeng ZhidongPeng Awaiting requested review from ZhidongPeng ZhidongPeng is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nagworld9 @narrieta @maddieford