suppress systemd-run error(Connection reset by peer) while validating ext cgroups #3278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagworld9
requested review from
narrieta,
ZhidongPeng and
maddieford
as code owners
narrieta
reviewed
Dec 19, 2024
| # It is possible that agent cgroup can be disabled due to UNKNOWN process or throttled before we run this check, in that case, we should ignore the validation | ||
| if check_cgroup_disabled_with_unknown_process() and retry_if_false(check_agent_quota_disabled): | ||
| log.info("Cgroup is disabled due to UNKNOWN process, ignoring ext cgroups validations") | ||
| # It is possible that agent cgroup can be disabled and reset the quotas if extension failed start using systemd-run. In that case, we should ignore the validation |
There was a problem hiding this comment.
Suggested change
| # It is possible that agent cgroup can be disabled and reset the quotas if extension failed start using systemd-run. In that case, we should ignore the validation | |
| # It is possible that agent cgroup can be disabled and reset the quotas if the extension failed to start using systemd-run. In that case, we should ignore the validation |
narrieta
approved these changes
Dec 19, 2024
maddieford
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cgroups may be disabled if there is a systemd-error while invoking any extension. As a result, extensions won't start in cgroups, and validation fail. This is expected behavior, so we are suppressing systemd error (Connection reset by peer)
Today, we did suppress for unknown process in agent cgroup but recently we improved the agent logic to determine unexpected processes. So, we shouldn't expect to see this unknown process error now and removing that in this pr.
Issue #
PR information
developbranch.Quality of Code and Contribution Guidelines