added POLICY_SPECIFICATION_FORMAT with possible values rawxml or xml.… #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… default is rawxml
|
@Banchio - thanks for the PR, but we won't be accepting this for now. We're making significant changes to the codebase that include "pervasive DI" (as per your feedback). In the meantime, we're not accepting changes to the existing code unless they're trivial or fix critical bugs. We don't have the bandwidth now to review extensive changes. The new code should be coming in the next few weeks. Please feel free to resubmit this feature then. |
|
Thanks for the feedback, responded as well on the issue. Did not want to be rude for the "pervasive DI" stuff but did not find a better way to express the concept :) |
|
No offense taken. Understood what you meant, and it was perfectly fair feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default value is rawxml.
I tried to maintain same approach as of now. Refactoring this to use pervasive DI would be a good maintainability improvement but out of scope for this PR.
As outline in #488 default extractor parameter is rawxml for policies file. Exported files may be read programmatically but more often than not, fails validation because of additional double quotes needed in particular instruction.
This PR adds a new parameter to choose between the two formats, default is as of today. Same parameter is added to the publisher as well. On this tool, publisher, an help with the tests would be greatly appreciated.