[Compute] az vm update: Add support of Gen1 VM to trusted launch upgrade
#29655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Compute |
microsoft-github-policy-service
bot
requested review from
zhoxing-ms and
yanzhudd
microsoft-github-policy-service
bot
added
the
Compute
Jing-song
commented
Aug 6, 2024
| os_disk_name=disk_name) | ||
| # Set --enable-secure-boot False and --enable-vtpm True if not specified by end user. | ||
| enable_secure_boot = enable_secure_boot if enable_secure_boot is not None else False | ||
| # Set --enable-secure-boot True and --enable-vtpm True if not specified by end user. |
There was a problem hiding this comment.
Request from service team: We should update Gen2 to Trusted launch upgrade logic and set --enable-secure-boot to true by default (if not specific by user).
Gen1 and Gen2 use the same logic
There was a problem hiding this comment.
Does modifying the default values seem to cause a breaking change in the customer's automated scripts or workflow?
There was a problem hiding this comment.
It'll not affect workflow or existing script.
Only potential risk is if they've unsigned drivers running on OS, they'll fail to load with OS boot. It is low % risk approved by Azure Security LT as acceptable.
zhoxing-ms
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az vm updateDescription
Gen1 VM to Trusted launch upgrade support
close #29007
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.