Add CodeQL buildidentifier for each platform #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucyzhang929
requested review from
Charles-Gagnon,
chlafreniere,
MaddyDev and
VasuBhog
as code owners
lucyzhang929
commented
Nov 30, 2023
| @@ -54,9 +51,13 @@ stages: | |||
| # Disabling integration tests on macOS due to issues with running MSSQL on Docker | |||
| # We need to set up a self-hosted agent with Docker running by default: https://github.com/microsoft/azure-pipelines-tasks/issues/12823 | |||
| testServer: '' | |||
| Codeql.BuildIdentifier: extension_mac | |||
| Codeql.Language: csharp,java,javascript,powershell,python,tsql | |||
There was a problem hiding this comment.
Note from CodeQL docs: "If repository contains an interpreted language, set Codeql.Language variable for that language in one of the stages/jobs to get full coverage."
I am setting the language for javascript, powershell, python, tsql only in the Mac job.
Charles-Gagnon
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses: #973
Adding a BuildIdentifier for each platform so that CodeQL scans correctly. More information about setting up CodeQL for pipelines with multiple stages/jobs: https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/codeql/codeql-codeql3000-faq#there-are-multiple-pipelines-or-stagesjobs-how-do-we-onboard