Transient IOError #331
Merged
Transient IOError #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results309 tests - 63 303 ✔️ - 63 3h 34m 24s ⏱️ + 1h 55m 0s Results for commit cc4890e. ± Comparison against base commit 484c34b. This pull request removes 73 and adds 10 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
AsafMah
reviewed
Nov 21, 2023
data/src/main/java/com/microsoft/azure/kusto/data/auth/CloudInfo.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #331 +/- ##
============================================
- Coverage 58.84% 56.00% -2.85%
+ Complexity 822 797 -25
============================================
Files 108 109 +1
Lines 4046 4071 +25
Branches 424 429 +5
============================================
- Hits 2381 2280 -101
- Misses 1476 1600 +124
- Partials 189 191 +2 ☔ View full report in Codecov by Sentry. |
…hodIsNotTable_EmptyIngestionStatus
AsafMah
reviewed
Nov 26, 2023
| import static org.mockito.ArgumentMatchers.*; | ||
| import static org.mockito.Mockito.*; | ||
|
|
||
| class ManagedStreamingIngestClientTest { |
There was a problem hiding this comment.
Why did you delete this whole file (if you moved it I can't see)
| @@ -272,11 +272,6 @@ | |||
| <artifactId>resilience4j-retry</artifactId> | |||
| <version>${resilience4j.version}</version> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
How do we know it's ok to remove?
There was a problem hiding this comment.
it was here only because the verify phase complained
| @@ -90,49 +92,69 @@ public static CloudInfo retrieveCloudInfoForCluster(String clusterUrl, | |||
| return cloudInfo; | |||
| } | |||
|
|
|||
| CloudInfo result; | |||
| for (int i = 0;; i++) { | |||
There was a problem hiding this comment.
The "ExponentialRetry" class did not fit here?
AsafMah
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
Following exception was raised and considered permanent
shaded.msdataflow.com.microsoft.azure.kusto.data.exceptions.DataServiceException: IOError when trying to retrieve CloudInfo
at shaded.msdataflow.com.microsoft.azure.kusto.data.auth.CloudInfo.retrieveCloudInfoForCluster(CloudInfo.java:122)
..
Caused by: java.net.ConnectException: Connection timed out (Connection timed out)
..
Caused by: org.apache.http.conn.HttpHostConnectException: Connect to ingest-pfclientquality.centralus.kusto.windows.net:443 [ingest-pfclientquality.centralus.kusto.windows.net/52.185.106.107] failed: Connection timed out (Connection timed out)
Aadded
Retry cloud info fetch
Split Utils to HttpPostUtils and Utils, so it now makes sense this class has the post() methods...
Wanted to move all http related classes to a new http package as i found it too crowded - but couldnt move HttpClientProperties as its used by client and therefore a breaking change, so its half way now and added todo to finish on next major