Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add async interface methods #38

Merged
merged 8 commits into from
Nov 28, 2018
Merged

Add async interface methods #38

merged 8 commits into from
Nov 28, 2018

Conversation

rabee333
Copy link
Contributor

#19 Implement async interface methods

@rabee333 rabee333 requested a review from limorl November 26, 2018 11:57
@rabee333
Made a few minor changes:
f6994e9 
- Returned the implementation to the original functions, and async functions use these ones.
- Modified exception messages.
@rabee333
Revert "Made a few minor changes:"
6e30b41 
This reverts commit f6994e9.
@rabee333 rabee333 merged commit 2741219 into OneWeek2018 Nov 28, 2018
@tamirkamara tamirkamara deleted the ingest-Async branch December 5, 2018 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirkamara tamirkamara tamirkamara left review comments

@limorl limorl limorl requested changes

@LizaShak LizaShak Awaiting requested review from LizaShak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rabee333 @limorl @tamirkamara