Azure identity second try #394
Conversation
# Conflicts: # .github/workflows/release.yml # data/src/main/java/com/microsoft/azure/kusto/data/auth/ApplicationKeyTokenProvider.java # data/src/main/java/com/microsoft/azure/kusto/data/auth/DeviceAuthTokenProvider.java # data/src/main/java/com/microsoft/azure/kusto/data/auth/UserPromptTokenProvider.java # data/src/main/java/com/microsoft/azure/kusto/data/instrumentation/MonitoredActivity.java # data/src/test/java/com/microsoft/azure/kusto/data/auth/AadAuthenticationHelperTest.java # ingest/src/test/java/com/microsoft/azure/kusto/ingest/E2ETest.java
| } catch (Exception e) { | ||
| throw new DataClientException(clusterUrl, ExceptionsUtils.getMessageEx(e), e); | ||
| } | ||
| protected Mono<String> acquireAccessTokenImpl() { |
There was a problem hiding this comment.
i see no reason to to use it like that
| @@ -141,7 +141,8 @@ public static void setUp() { | |||
| @AfterAll | |||
| public static void tearDown() { | |||
| try { | |||
| queryClient.executeToJsonResult(DB_NAME, String.format(".drop table %s ifexists skip-seal", tableName)); | |||
| new ExponentialRetry<DataServiceException, DataClientException>(2) | |||
There was a problem hiding this comment.
I think it's an holdover from when the tests failed, I'll undo it
|
Apologies for interrupting your PR. I just wanted to ask you about the async operations, as I noticed Asaf made some steps in that direction in this PR. If you'd prefer to continue this discussion in another section, please let me know! Are async operations still on the roadmap for the SDK? I've implemented changes to enable the Client interface to fully support async operations (using Project Reactor's Mono, just like the Azure core HTTP client returns). This includes making all Client methods asynchronous (on authentication as well, though I'm currently waiting for updates from this PR before finalizing that part). I understand that this type of change requires extensive testing, but I would be willing to continue working on it and submit a draft PR for your review to showcase the changes. Let me know if this aligns with your plans, or if you’d prefer to approach this differently. Thank you! |
|
We do want to move to async, any contribution would be welcome. |
|
Great! After your PR, I'll finish up with authentication and continue with ingest. I'll keep you guys updated! |
No description provided.