Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused timeout from HttpClientProperties and ResourceManager #395

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

yihezkel
Copy link
Member

@yihezkel yihezkel commented Nov 6, 2024

Returning old computer as I'm upgrading to a new computer, and found these minor improvements lying around locally.

Copy link

github-actions bot commented Nov 6, 2024

Test Results

326 tests  ±0   318 ✅ ±0   3m 37s ⏱️ +32s
 27 suites ±0     8 💤 ±0 
 27 files   ±0     0 ❌ ±0 

Results for commit 93787e9. ± Comparison against base commit 84218c1.

♻️ This comment has been updated with latest results.

@ohadbitt
Copy link
Collaborator

the timeout is already fixed in my PR
the slf4j- i dont see the need - do you think its neede ?

@yihezkel yihezkel changed the title Miscellaneous minor improvements Remove unused timeout from HttpClientProperties and ResourceManager Nov 11, 2024
@yihezkel yihezkel merged commit ab29102 into master Nov 12, 2024
8 checks passed
@yihezkel yihezkel deleted the miscellaneousMinorImprovements branch November 12, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants