Fix headers escaping and parsing #531
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to reason about:
- Only allowed chars: [a-zA-Z0-9_.\-()] (Note: not using \w because we don't want non-ascii chars)
- Escape every part of the header, even when using set_connector_details
- Remove the brackets around escaped fields, as they are not needed to parse anymore. So
- Parsing is now simply splitting by |, and then you have pairs of key:value.
- Limit the length of each field to 100
So old:
Kusto.Café:{1 . 0}|App.{Something}:{weird version}
New:
Kusto.Caf_:1_._0|App.Something:weird_version
…r to reason about:
- Only allowed chars: [a-zA-Z0-9_.\-()] (Note: not using \w because we don't want non-ascii chars)
- Escape every part of the header, even when using set_connector_details
- Remove the brackets around escaped fields, as they are not needed to parse anymore. So
- Parsing is now simply splitting by |, and then you have pairs of key:value.
- Limit the length of each field to 100
So old:
Kusto.Café:{1 . 0}|App.{Something}:{weird version}
New:
Kusto.Caf_:1_._0|App.Something:weird_version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the tracing format to be always allowed in headers, and easier to reason about:
So old: Kusto.Café:{1 . 0}|App.{Something}:{weird version}
New: Kusto.Caf_:1_._0|App.Something:weird_versio