Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth metadata endpoint is always rooted #559

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alonadam
Copy link
Contributor

Changed

Auth metadata endpoint is always relative to the cluster URI

Copy link

github-actions bot commented Dec 22, 2024

Test Results

    6 files  ±0      6 suites  ±0   16m 51s ⏱️ - 3m 31s
  294 tests ±0    260 ✅  -  8   34 💤 + 8  0 ❌ ±0 
1 764 runs  ±0  1 560 ✅  - 48  204 💤 +48  0 ❌ ±0 

Results for commit 9d90bac. ± Comparison against base commit 82d18b5.

This pull request skips 8 tests.
azure-kusto-data.tests.test_e2e_data.TestE2E ‑ test_no_redirects_fail_in_cloud[301]
azure-kusto-data.tests.test_e2e_data.TestE2E ‑ test_no_redirects_fail_in_cloud[302]
azure-kusto-data.tests.test_e2e_data.TestE2E ‑ test_no_redirects_fail_in_cloud[307]
azure-kusto-data.tests.test_e2e_data.TestE2E ‑ test_no_redirects_fail_in_cloud[308]
azure-kusto-data.tests.test_e2e_data.TestE2E ‑ test_no_redirects_fail_in_cloud_async[301]
azure-kusto-data.tests.test_e2e_data.TestE2E ‑ test_no_redirects_fail_in_cloud_async[302]
azure-kusto-data.tests.test_e2e_data.TestE2E ‑ test_no_redirects_fail_in_cloud_async[307]
azure-kusto-data.tests.test_e2e_data.TestE2E ‑ test_no_redirects_fail_in_cloud_async[308]

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (51c5129) to head (9d90bac).
Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #559      +/-   ##
==========================================
+ Coverage   87.71%   88.03%   +0.31%     
==========================================
  Files          44       44              
  Lines        3754     3752       -2     
==========================================
+ Hits         3293     3303      +10     
+ Misses        461      449      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alonadam alonadam requested a review from AsafMah December 22, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant