Merge branch 'main' into simplified-ingest-client

.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,31 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**Setup (please complete the following information):**
+ - rust version [e.g 1.74.1 (f571d3945c 2023-12-08)]
+ - SDK commit id [e.g 5deb758..]
+
+**Desktop (please complete the following information):**
+ - OS: [e.g. iOS]
+ - Version [e.g. 22]
+
+**Additional context**
+Add any other context about the problem here.

.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,20 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

.github/workflows/build.yml

@@ -1,30 +1,38 @@
-on: [push]
+on:
+  push:
+    branches: [ 'main' ]
+  pull_request:
+    branches: [ '**' ]
 
 name: Rust Build, Test, and Lint
+permissions:
+  checks: write
+  pull-requests: write
+  id-token: write
+  contents: read
 
 jobs:
   build-data:
     runs-on: ubuntu-latest
-    environment: sdke2e
+    environment: build
     env:
       RUST_BACKTRACE: 1
       RUST_LOG: debug
-      KUSTO_CLUSTER_URL: https://sdkse2etest.eastus.kusto.windows.net
-      KUSTO_DATABASE: fastbatchinge2e
-      AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }}
-      AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }}
-      AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }}
     steps:
+      - name: Azure login
+        uses: azure/login@v2
+        with:
+          client-id: ${{ secrets.AZURE_CLIENT_ID }}
+          tenant-id: ${{ secrets.AZURE_TENANT_ID }}
+          subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}
       - uses: actions/checkout@v1
       - uses: actions-rs/toolchain@v1
         with:
           toolchain: nightly
           override: true
           components: rustfmt, clippy
       - uses: Swatinem/rust-cache@v2
-      - uses: mbrobbel/rustfmt-check@master
-        with:
-          token: ${{ secrets.GITHUB_TOKEN }}
+      - run: cargo fmt --all -- --check
       - uses: actions-rs/clippy-check@v1
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
@@ -44,6 +52,8 @@ jobs:
           CARGO_INCREMENTAL: '0'
           RUSTFLAGS: '-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests'
           RUSTDOCFLAGS: '-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests'
+          KUSTO_CLUSTER_URL: https://sdkse2etest.eastus.kusto.windows.net
+          KUSTO_DATABASE: fastbatchinge2e
       - uses: actions-rs/grcov@v0.1
         id: coverage
       - name: Publish Unit Test Results

README.md

@@ -14,7 +14,7 @@ See the SDK [best practices guide](https://docs.microsoft.com/azure/data-explore
 - **Have a feature request for SDKs?** Please post it on [User Voice](https://feedback.azure.com/forums/915733-azure-data-explorer) to help us prioritize
 - **Have a technical question?** Ask on [Stack Overflow with tag "azure-data-explorer"](https://stackoverflow.com/questions/tagged/azure-data-explorer)
 - **Need Support?** Every customer with an active Azure subscription has access to [support](https://docs.microsoft.com/en-us/azure/azure-supportability/how-to-create-azure-support-request) with guaranteed response time. Consider submitting a ticket and get assistance from Microsoft support team
-- **Found a bug?** Please help us fix it by thoroughly documenting it and [filing an issue](https://github.com/Azure/azure-kusto-python/issues/new).
+- **Found a bug?** Please help us fix it by thoroughly documenting it and [filing an issue](https://github.com/Azure/azure-kusto-rust/issues/new).
 
 ## Looking for SDKs for other languages/platforms?
 

azure-kusto-data/Cargo.toml

@@ -44,7 +44,7 @@ once_cell = "1"
 arrow = { version = "50.0.0", features = ["prettyprint"] }
 dotenv = "0.15.0"
 env_logger = "0.10.0"
-tokio = { version = "1.25.0", features = ["macros"] }
+tokio = { version = "1.25.0", features = ["macros", "rt-multi-thread"] }
 oauth2 = "4.3.0"
 criterion = "0.5"
 clap = { version = "4.1.6", features = ["derive", "env"] }

azure-kusto-data/README.md

@@ -5,4 +5,4 @@
 `azure-data-kusto` offers functionality needed to interact with Azure Data Explorer (Kusto) from Rust.
 As an abstraction over the [Azure Data Explorer REST API](https://docs.microsoft.com/en-us/azure/data-explorer/kusto/api/rest/)
 
-For usage have a look at the [examples](https://github.com/Azure/azure-sdk-for-rust/tree/main/sdk/data_kusto/examples).
+For usage have a look at the [examples](https://github.com/Azure/azure-kusto-rust/tree/main/azure-kusto-data/examples).

azure-kusto-data/src/cloud_info.rs

@@ -62,7 +62,7 @@ impl CloudInfo {
         );
         request.insert_headers(&Accept::from("application/json"));
         request.insert_headers(&AcceptEncoding::from("gzip, deflate"));
-        let response = pipeline.send(&mut Context::new(), &mut request).await?;
+        let response = pipeline.send(&Context::new(), &mut request).await?;
         let (status_code, _header_map, pinned_stream) = response.deconstruct();
         match status_code {
             StatusCode::Ok => {

azure-kusto-data/src/operations/query.rs

@@ -77,11 +77,7 @@ impl QueryRunner {
         let bytes = bytes::Bytes::from(serde_json::to_string(&body)?);
         request.set_body(bytes);
 
-        let response = self
-            .client
-            .pipeline()
-            .send(&mut context, &mut request)
-            .await?;
+        let response = self.client.pipeline().send(&context, &mut request).await?;
         Ok(response)
     }