Make the tool ready to hook a list of fragblobs for vtt file generati… #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on for LiveToVOD asset Description: Take use of the close caption track that contains a list of fragblobs for the final VTT file generation. Hook the packager to read a list of close caption fragblobs, figure out the ttml text from the fragblobs, pass the ttml text to the converter for vtt content. Append all the VTT content into a single .vtt file for ShakaPackager to consume. The actual TTML to VTT text converter is not included in this change. Add a new property TrackName in Track class. Fix a bug in ClientManifest class when it tries to figure out a matching StreamIndex and QualityLevel for a specific track.
weibz
requested review from
duggaraju,
pohhsu,
BruceLin-MS and
melindawangmsft
pohhsu
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on for LiveToVOD asset
Description:
Take use of the close caption track that contains a list of fragblobs for the final VTT file generation.
Hook the packager to read a list of close caption fragblobs, figure out the ttml text from the fragblobs,
pass the ttml text to the converter for vtt content.
Append all the VTT content into a single .vtt file for ShakaPackager to consume.
The actual TTML to VTT text converter is not included in this change.
Add a new property TrackName in Track class.
Fix a bug in ClientManifest class when it tries to figure out a matching StreamIndex and QualityLevel for a specific track.