Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the NBest Subtitle track for ShakaPackager #181

Merged
merged 1 commit into from
Sep 14, 2023

Commits on Sep 14, 2023

  1. Disable the NBest Subtitle track for ShakaPackager

    Description:
    
      The NBest track wtih .vtt file is not directly used by our AMS origin server today,
      and the cues inside the vtt file might be in wrong order in some cases.
    
      This change just disable the NBest track when ShakaPackager is used to generate DASH/HLS manifests.
    
      For LiveToVOD asset, the track with .vtt as its source is treated as NBest track.
    
      For asset generated by MES Copy job, it may generate multiple text tracks with .cmft file which are generated from the .vtt files,
      In this case, keep one CMFT track for each language,  the one with the biggest vtt file size is used for that language, other close caption tracks are not used for ShakaPackager.
    
      Even though those vtt files are not used by ShakaPackager, but the cue timestamps are still adjusted to match with new audio/video timelines, and the updated vtt files are copied over to the destination folder
      for the asset owner to consume them with other tools.
    
      The change keep uses the current design, and extend it by using the settings of the matching Manifiest item in the Manifest list, if the match track is not used
      by the ShakaPackager, the value of Manifest list for that track is set to "", so that the packager knows how to deal with it.
    
      The change also contains a minor fix where it always uploaded the .vtt files in advance when the asset contains cmft file as track source which are generated from .vtt file,
      since the vtt files are updated and used by ShakaPackager, the pre-uploading should not directly upload vtt files for this asset.
    weibz committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    88ffece View commit details
    Browse the repository at this point in the history