Add LocatorIds into the report page for asset analyzer command #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: When reporting the result to HTML page, to help customers to figure out the mapping between streaing Url on input asset and the streaming URL of the generated output asset, this change adds a new column in the report page to include LocatorIds for each input asset, if the locatorIds (Guid) are available. One input can have zero or multiple locatorIds, when it has multiple locatorIds, the report page uses ";---------" as a separator line between two locators. Adjust the percentage of each column in the report page, use it as guideline, the column length is not guaranteed if the asset name contains a word with a long list of characters without separators like ',-' etc. Some minor fix to make it report correct number of assets without locators.
weibz
requested review from
duggaraju,
pohhsu,
BruceLin-MS and
melindawangmsft
…instead a plain string So that it is easier to work with both JSON and HTML report page.
pohhsu
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When reporting the result to HTML page, to help customers to figure out the mapping
between streaing Url on input asset and the streaming URL of the generated output asset,
this change adds a new column in the report page to include LocatorIds for each input asset,
if the locatorIds (Guid) are available.
One input can have zero or multiple locatorIds, when it has multiple locatorIds, the report page uses
";---------" as a separator line between two locators.
Adjust the percentage of each column in the report page, use it as guideline, the column length is not guaranteed
if the asset name contains a word with a long list of characters without separators like ',-' etc.
Some minor fix to make it report correct number of assets without locators.