Update shaka-packager to v3.2.0 #253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schuettecarsten
force-pushed
the
pr/update-shaka-packager-v3.2.0
branch
from
e59133f
to
aefd388
Compare
|
Do you want to update the README.md that VC redist is required on Windows and where to get tit. I am all up for updating shaka since we had some fixes contributed but the release wasn't available back then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update shaka-packager to v3.2.0, on my tests the migration still works and I ran into no new issues.
Please note that the new version of shaka-packager for Windows requires latest vc_redist.x64.exe from https://aka.ms/vs/17/release/vc_redist.x64.exe