Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@azure/monitor-opentelemetry ignoes AZURE_LOG_LEVEL setting when APPLICATIONINSIGHTS_INSTRUMENTATION_LOGGING_LEVEL is not set #30660

Closed
1 of 6 tasks
PlayAnyData opened this issue Aug 6, 2024 · 1 comment
Closed
1 of 6 tasks

@azure/monitor-opentelemetry ignoes AZURE_LOG_LEVEL setting when APPLICATIONINSIGHTS_INSTRUMENTATION_LOGGING_LEVEL is not set #30660

PlayAnyData opened this issue Aug 6, 2024 · 1 comment
Assignees
@hectorhdzg
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@PlayAnyData
Copy link
Contributor

  • Package Name: @azure/monitor-opentelemetry
  • Package Version: 1.6.0
  • Operating system:
  • nodejs
    • version: 20
  • browser
    • name/version:
  • typescript
    • version:
  • Is the bug related to documentation in

Describe the bug
When AZURE_LOG_LEVEL is set and APPLICATIONINSIGHTS_INSTRUMENTATION_LOGGING_LEVEL is not set, the AZURE_LOG_LEVEL should be used. Instead, azure log level is ignored.

To Reproduce
Steps to reproduce the behavior:

  1. Set AZURE_LOG_LEVEL and do not set APPLICATIONINSIGHTS_INSTRUMENTATION_LOGGING_LEVEL

Expected behavior
AZURE_LOG_LEVEL is expected to be used.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.
@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 6, 2024
@PlayAnyData PlayAnyData mentioned this issue Aug 6, 2024
Merged
3 tasks
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. Monitor - Exporter Monitor OpenTelemetry Exporter labels Aug 6, 2024
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 6, 2024
@jeremymeng jeremymeng added Service Attention Workflow: This issue is responsible by Azure service team. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Aug 6, 2024
@github-actions github-actions bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 6, 2024
@jeremymeng jeremymeng removed the Service Attention Workflow: This issue is responsible by Azure service team. label Aug 6, 2024
@github-actions github-actions bot added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Aug 6, 2024
xirzec added a commit that referenced this issue Aug 8, 2024
@PlayAnyData @xirzec
fix: default for AZURE_LOG_LEVEL (#30661)
d4ab19b 
### Packages impacted by this PR
@azure/monitor-opentelemetry

### Issues associated with this PR
#30660

### Describe the problem that is addressed by this PR
The default set by AZURE_LOG_LEVEL is ignored

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?
Change the value in the line above to conform to upper. I felt it is
better to overwrite the default, as in essence AZURE_LOG_LEVEL is the
default for this.


### Are there test cases added in this PR? _(If not, why?)_
No, haven't been any before as well :-P

### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [X] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)

---------

Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
@JacksonWeber
Copy link
Member

Marking as closed by #30661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hectorhdzg hectorhdzg

Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Monitor - Exporter Monitor OpenTelemetry Exporter needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jeremymeng @hectorhdzg @JacksonWeber @PlayAnyData