fix: default for AZURE_LOG_LEVEL #30661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlayAnyData
requested review from
hectorhdzg,
JacksonWeber and
harsimar
as code owners
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @PlayAnyData! We will review the pull request and get back to you soon. |
xirzec
reviewed
Aug 6, 2024
|
@microsoft-github-policy-service agree company="Functional GmbH" |
|
API change check API changes are not detected in this pull request. |
xirzec
approved these changes
Aug 7, 2024
xirzec
reviewed
Aug 7, 2024
hectorhdzg
approved these changes
Aug 7, 2024
Co-authored-by: Jeff Fisher <xirzec@xirzec.com>
|
You are welcome. And thanks as well :-) |
|
Looks like prettier is complaining, |
|
Formatted. Let's see ;-) |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/monitor-opentelemetry
Issues associated with this PR
#30660
Describe the problem that is addressed by this PR
The default set by AZURE_LOG_LEVEL is ignored
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Change the value in the line above to conform to upper. I felt it is better to overwrite the default, as in essence AZURE_LOG_LEVEL is the default for this.
Are there test cases added in this PR? (If not, why?)
No, haven't been any before as well :-P
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists