[Test-Credential] Update to Azure Pipeline Credential #30633
Merged
+55
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test-utils
minhanh-phan
changed the title
|
Template pipeline succeeds with Azure Pipelines Credential here. The samples step failing is unrelated to this PR |
timovv
reviewed
Aug 6, 2024
minhanh-phan
requested review from
jeremymeng,
mpodwysocki and
HarshaNalluru
as code owners
minhanh-phan
requested review from
ckairen,
mikeharder,
weshaggard and
benbp
as code owners
… test-credential/update
HarshaNalluru
pushed a commit
to HarshaNalluru/azure-sdk-for-js
that referenced
this pull request
Sep 3, 2024
---------------------------- [Test-Credential] Update to Azure Pipeline Credential (Azure#30633) test-credential Update the `createTestCredential` to use Azure Pipeline Credential when in the Dev Ops env
HarshaNalluru
added a commit
that referenced
this pull request
Sep 3, 2024
### Packages impacted by this PR `@azure-tools/test-credential@v1` will now depend on the Azure Pipelines Credential. Impacts the live test pipelines for all the packages leveraging `test-credential@v1` Ports the PR #30633 --------- Co-authored-by: Minh-Anh Phan <111523473+minhanh-phan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
test-credential
Issues associated with this PR
Describe the problem that is addressed by this PR
Update the
createTestCredentialto use Azure Pipeline Credential when in the Dev Ops envWhat are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists