Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt ASO-specific label to replace default control-plane: controller-manager #4465

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bingikarthik
Copy link
Contributor

@bingikarthik bingikarthik commented Nov 22, 2024

What this PR does

Closes #4277

Current Behavior:
The kubebuilder default label control-plane: controller-manager is currently used. This label is common across many projects, which can lead to potential conflicts, especially when multiple deployments or webhooks exist in the same namespace. Such conflicts may cause misrouting of resources and selectors, impacting functionality.

Improvement:
This PR introduces a unique label specific to ASO, ensuring better namespace coexistence and reducing the risk of conflicts with other deployments. By aligning with best practices, this change improves ASO's compatibility and coexistence within shared Kubernetes environments.

Impact:

  • Avoids label conflicts with other projects.
  • Supports installation alongside other controllers in the same namespace.
  • Enhances stability and maintainability of deployments using ASO.

This update addresses potential selector misconfigurations and promotes more robust operations in multi-controller setups.

How does this PR make you feel?

gif

Checklist

  • this PR contains documentation
  • this PR contains tests
  • this PR contains YAML Samples

@matthchr
Copy link
Member

We are interested in doing something like this, but as called out in the linked issue #4277, just making this doesn't work I don't think because it can't be changed on existing deployments. I think we'll need something more involved, though I also need to check if changing the deployment mode to Recreate makes this any easier.

@bingikarthik
Copy link
Contributor Author

Yes, agree this won't apply on existing deployments! To apply probably deployment strategy to have: Recreate(i.e., need to rollout following PR: #4466)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Use a more specific selector than control-plane: controller-manager
2 participants