Adopt ASO-specific label to replace default control-plane: controller-manager #4465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Closes #4277
Current Behavior:
The kubebuilder default label
control-plane: controller-manager
is currently used. This label is common across many projects, which can lead to potential conflicts, especially when multiple deployments or webhooks exist in the same namespace. Such conflicts may cause misrouting of resources and selectors, impacting functionality.Improvement:
This PR introduces a unique label specific to ASO, ensuring better namespace coexistence and reducing the risk of conflicts with other deployments. By aligning with best practices, this change improves ASO's compatibility and coexistence within shared Kubernetes environments.
Impact:
This update addresses potential selector misconfigurations and promotes more robust operations in multi-controller setups.
How does this PR make you feel?
Checklist