Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Simplification #1578

Merged
merged 3 commits into from
Nov 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sampleBlockCacheConfig.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,5 @@ azstorage:
type: block
account-name: <ACCOUNT_NAME>
account-key: <ACCOUNT_KEY>
endpoint: https://<ACCOUNT_NAME>.blob.core.windows.net
mode: key
container: <CONTAINER_NAME>
1 change: 0 additions & 1 deletion sampleFileCacheConfig.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,5 @@ azstorage:
type: block
account-name: <ACCOUNT_NAME>
account-key: <ACCOUNT_KEY>
endpoint: https://<ACCOUNT_NAME>.blob.core.windows.net
mode: key
container: <CONTAINER_NAME>
1 change: 0 additions & 1 deletion sampleFileCacheWithSASConfig.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ azstorage:
type: block
account-name: <ACCOUNT_NAME>
sas: <SAS_TOKEN>
endpoint: https://<ACCOUNT_NAME>.blob.core.windows.net
mode: sas
container: <CONTAINER_NAME>

32 changes: 0 additions & 32 deletions sampleStreamingConfig.yaml

This file was deleted.

2 changes: 1 addition & 1 deletion setup/advancedConfig.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ azstorage:
type: block|adls <type of storage account to be connected. Default - block>
account-name: <name of the storage account>
container: <name of the storage container to be mounted>
endpoint: <storage account endpoint (example - https://account-name.blob.core.windows.net)>
endpoint: <specify this parameter only if storage account is behind a private endpoint>
mode: key|sas|spn|msi|azcli <kind of authentication to be used>
account-key: <storage account key>
# OR
Expand Down
2 changes: 1 addition & 1 deletion setup/baseConfig.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ azstorage:
type: block|adls <type of storage account to be connected. Default - block>
account-name: <name of the storage account>
container: <name of the storage container to be mounted>
endpoint: <storage account endpoint (example - https://account-name.blob.core.windows.net)>
endpoint: <specify this parameter only if storage account is behind a private endpoint>
mode: key|sas|spn|msi|azcli <kind of authentication to be used>
account-key: <storage account key>
# OR
Expand Down
Loading