Skip to content

Commit

Permalink
Fixing the NOTE in cran check (#236)
Browse files Browse the repository at this point in the history
* Installing R SDK from CRAN

* Resolving PR comments

* Fixing code quality
  • Loading branch information
heemanshusuri authored Feb 5, 2020
1 parent 21b8363 commit d1c1cc8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
4 changes: 3 additions & 1 deletion R/run.R
Original file line number Diff line number Diff line change
Expand Up @@ -680,11 +680,13 @@ view_run_details <- function(run, auto_refresh = TRUE) {
shiny::shinyOptions,
Sys.time())

.envir <- as.environment(1)

lapply(seq_along(widget_obj_names),
function(x) {
assign(widget_obj_names[[x]],
widget_obj_vals[[x]],
envir = .GlobalEnv)
envir = .envir)
}
)

Expand Down
7 changes: 1 addition & 6 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,4 @@ This is a minor release.
* win-builder: windows-x86_64-devel

## R CMD check results
0 errors | 0 warnings | 1 note
Adressing the note:
* Found the following assignments to the global environment:
File 'azuremlsdk/R/run.R':
assign(widget_obj_names[[x]], widget_obj_vals[[x]], envir = .GlobalEnv)
* The widgets run as a background job and have to access these variables in order to function successfully. The only way it could work is if these variables are added to the Global Environment so that they are available to the application.
0 errors | 0 warnings | 0 notes

0 comments on commit d1c1cc8

Please sign in to comment.