-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Updated Automation-Account CMK Implementation #3730
base: main
Are you sure you want to change the base?
feat: Updated Automation-Account CMK Implementation #3730
Conversation
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note, the main.json
templates must be re-build with the latest Bicep version 0.31.34
as this version (running on the agents) renders a different main.json
file then previous versions.
The steps to execute would be
- Upgrade your Bicep CLI version to
0.31.34
(e.g. viachoco upgrade bicep
if choco is used) - Re-run the
Set-AVMModule
script on your module. E.g. viaSet-AVMModule -ModuleFolderPath '.\avm\res\automation\automation-account\' -SkipFileAndFolderSetup -SkipReadMe -Recurse
- Push the changes
- Re-run the tests to ensure everything works.
If the static tests continue to fail for you, please note that there is currently presumably another new bug which affects some of our modules (ref).
Hey @AlexanderSehr , Firstly, thanks for your work on this PR! We have made some changes to the AVM CI, detailed below, which means we need you to update your fork to pull in these latest changes and re-run your tests to show they still are passing prior to approving and merging this PR, as we don't and it fails once merged the publishing of your module will fail and will be blocked going forward until the test pass again via additional PRs. Changes to CI That Have Been Made That You Need To Take Action On
Any questions reach out to the AVM Core Team by tagging us in your PR here or internally via Teams Thanks Jack (AVM Core Team) |
Description
Linked to
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.