Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSTest.TestAdapter from 3.3.1 to 3.4.0 in /src/vs-bicep #14177

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 26, 2024

Bumps MSTest.TestAdapter from 3.3.1 to 3.4.0.

Release notes

Sourced from MSTest.TestAdapter's releases.

v3.4.0

Here are the highlights of the current release, full change log is available below:

microsoft/testfx@v3.3.1...v.3.4.0

MSTest

New and improved analyzers

We've added more code analyzers to help you prevent mistakes, and to ensure a consistent code style of your tests.

One example of a new analyzer that was added in 3.4.0 is MSTEST0024: Do not store TestContext in static members. This analyzer has info severity by default, and will show a message, when you store TestContext in a static member in your class. This is not recommended, and you should be using a TestContext property instead:

image

The other analyzers added in this release:

If you've just learned about MSTest analyzers, please also check out the analyzers that were added in previous releases. They will help you ensure that your test classes and test methods are recognized by MSTest and are not accidentally ignored.

The analyzers are automatically installed with the MSTest NuGet meta-package. But can also be installed separately using the MSTest.Analyzers NuGet package.

More timeout options

Timeout can now be specified on all fixture methods, including ClassCleanup, AssemblyCleanup, TestCleanup and TestInitalize. In this case I want my [ClassCleanup] to time out after 1 second:

image

Alternatively timeouts can be specified through runsettings. For example like this:

<RunSettings>
  <MSTest>
    <ClassCleanupTimeout>1000</ClassCleanupTimeout>
  </MSTest>
</RunSettings>

Better errors on data mismatch

When you provide data that don't match your test method signature, the test will fail with an informative message, rather than just "Parameter count mismatch.".

... (truncated)

Changelog

Sourced from MSTest.TestAdapter's changelog.

[3.4.0] - 2023-05-23

See full log here

Added

Fixed

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com//pull/14177)

Bumps [MSTest.TestAdapter](https://github.com/microsoft/testfx) from 3.3.1 to 3.4.0.
- [Release notes](https://github.com/microsoft/testfx/releases)
- [Changelog](https://github.com/microsoft/testfx/blob/main/docs/Changelog.md)
- [Commits](microsoft/testfx@v3.3.1...v3.4.0)

---
updated-dependencies:
- dependency-name: MSTest.TestAdapter
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file vs-bicep-dependencies dependabot PRs created for the Bicep VS extension code labels May 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) May 26, 2024 23:56
@microsoft-github-policy-service microsoft-github-policy-service bot added the auto-merge Automatically merge this PR label May 26, 2024
Copy link
Contributor

@microsoft-github-policy-service microsoft-github-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@microsoft-github-policy-service microsoft-github-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@microsoft-github-policy-service microsoft-github-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

github-actions bot commented May 27, 2024

Dotnet Test Results

    65 files   -     34      65 suites   - 34   22m 25s ⏱️ - 10m 3s
10 874 tests  -     20  10 873 ✅  -     20  1 💤 ±0  0 ❌ ±0 
25 644 runs   - 12 818  25 642 ✅  - 12 817  2 💤  - 1  0 ❌ ±0 

Results for commit 58ee762. ± Comparison against base commit 03f9f95.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 27, 2024

Test this change out locally with the following install scripts (Action run 9278216392)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 9278216392
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 9278216392"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 9278216392
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 9278216392"

auto-merge was automatically disabled May 28, 2024 19:46

Pull request was closed

Copy link
Contributor Author

dependabot bot commented on behalf of github May 28, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@StephenWeatherford
Copy link
Contributor

Forcing rebuild

@StephenWeatherford StephenWeatherford merged commit 6601329 into main May 29, 2024
46 checks passed
@StephenWeatherford StephenWeatherford deleted the dependabot/nuget/src/vs-bicep/MSTest.TestAdapter-3.4.0 branch May 29, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge this PR dependencies Pull requests that update a dependency file vs-bicep-dependencies dependabot PRs created for the Bicep VS extension code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant