Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use collection expression #14318

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

Meir017
Copy link
Contributor

@Meir017 Meir017 commented Jun 13, 2024

resolves #14295

Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@anthony-c-martin anthony-c-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these rules!

@anthony-c-martin anthony-c-martin enabled auto-merge (squash) June 13, 2024 13:19
@anthony-c-martin anthony-c-martin force-pushed the chore/use-collection-expression branch from aa4b850 to d75984b Compare June 13, 2024 17:41
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.71%. Comparing base (108d816) to head (04d2428).
Report is 669 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #14318       +/-   ##
===========================================
- Coverage   94.28%    7.71%   -86.57%     
===========================================
  Files        1113        7     -1106     
  Lines      100791      350   -100441     
  Branches     8734      127     -8607     
===========================================
- Hits        95028       27    -95001     
+ Misses       4595      323     -4272     
+ Partials     1168        0     -1168     
Flag Coverage Δ
dotnet ?
typescript 7.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1105 files with indirect coverage changes

@anthony-c-martin anthony-c-martin force-pushed the chore/use-collection-expression branch from d75984b to 04d2428 Compare June 13, 2024 18:50
@anthony-c-martin anthony-c-martin merged commit eae676e into Azure:main Jun 13, 2024
37 checks passed
Copy link
Contributor

Test this change out locally with the following install scripts (Action run 9505277323)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 9505277323
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 9505277323"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 9505277323
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 9505277323"

@Meir017 Meir017 deleted the chore/use-collection-expression branch June 13, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants