update build script to include ncc install #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gh actions won't respect npx installed devdeps
erinborders
approved these changes
Feb 7, 2024
jaiveerk
approved these changes
Feb 7, 2024
OliverMKing
reviewed
Feb 7, 2024
| @@ -4,7 +4,7 @@ | |||
| "private": true, | |||
| "main": "lib/index.js", | |||
| "scripts": { | |||
| "build": "ncc build src/run.ts -o lib", | |||
| "build": "npm i ncc && npx ncc build src/run.ts -o lib", | |||
There was a problem hiding this comment.
should installing ncc be a prebuild using npm pre scripts?
There was a problem hiding this comment.
that's a good point
ideally it would just get installed via dev dependencies and then we can invoke via npx but for some reason that fails on gh action runners
i can test a prebuild script on a fork to confirm
duje-begonja-rdx
added a commit
to RDXWorks-actions/setup-kubectl
that referenced
this pull request
Apr 30, 2024
* Bump node to version 20 (Azure#90) * Bump @babel/traverse from 7.18.6 to 7.23.9 (Azure#93) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.18.6 to 7.23.9. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.9/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * migrate to new azure release workflow (Azure#95) * migrate to new azure release workflow * format * Bump word-wrap from 1.2.3 to 1.2.4 (Azure#83) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump semver from 5.7.1 to 5.7.2 (Azure#82) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump tough-cookie from 4.0.0 to 4.1.3 (Azure#81) Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.0.0 to 4.1.3. - [Release notes](https://github.com/salesforce/tough-cookie/releases) - [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md) - [Commits](salesforce/tough-cookie@v4.0.0...v4.1.3) --- updated-dependencies: - dependency-name: tough-cookie dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * v4 release (Azure#96) * Update release-pr.yml (Azure#98) * update build script to include ncc install (Azure#99) gh actions won't respect npx installed devdeps * Update release-pr.yml (Azure#101) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Per Karlsson <per.karlsson@me.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Gamero <david340804@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh actions won't respect npx installed devdeps, so i added the install to the build script and called through npx