Enable Kdump config by default for cisco-8000 #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aman Singhal <amans@cisco.com>
|
@abdosi Pls help merge this double-commit from master, thanks. |
|
@amnsinghal how this change will be useful for 202205 image ? @anamehra for viz. |
@abdosi We use sonic-buildimage 202205 branch for Cisco builds, thanks. |
|
@abdosi Can you pls merge this double-commit, if no further comments, thanks. |
abdosi
approved these changes
Sep 20, 2023
jon-nokia
pushed a commit
to jon-nokia/sonic-buildimage-msft
that referenced
this pull request
Sep 25, 2023
…atically (#15522) src/sonic-telemetry * a4bfafe - (HEAD -> 202205, origin/202205) Merge pull request Azure#119 from zbud-msft/202205_gnmi_get_log (5 hours ago) [Ying Xie] * 1b49409 - Merge branch '202205' into 202205_gnmi_get_log (7 days ago) [Zain Budhwani] * b478159 - Cherry pick commit 4a8964a (Azure#104) (7 days ago) [Zain Budhwani]
jon-nokia
pushed a commit
to jon-nokia/sonic-buildimage-msft
that referenced
this pull request
May 3, 2024
…omatically (#16744) #### Why I did it src/sonic-mgmt-common ``` * 7e3a8ad - (HEAD -> master, origin/master, origin/HEAD) Transformer infra enhancements and bug fixes (Azure#104) (5 days ago) [amrutasali] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double-commit from master: sonic-net/sonic-buildimage#16224
Why I did it
Enabling kdump by default for cisco-8000 by setting crashkernel cmdline arg in device installer.conf.
After bootup, sonic-kdump-config wipes crashkernel arg from /host/grub/grub.cfg, and resets USE_KDUMP in /etc/default/kdump-tools, so kdump will not be enabled on subsequent reboot.
How I did it
Setting kdump enable config as part of init_cfg.json for cisco-8000 platforms.
How to verify it
Install SONiC image with kdump enabled by default (device/hwsku/installer.conf), then reboot.
Kdump config should persist on subsequent reboots and kdump loaded during bootup.