Skip to content

Commit

Permalink
fix: update node to 18 in dockerfile (#755)
Browse files Browse the repository at this point in the history
  • Loading branch information
cjk7989 authored Nov 2, 2023
1 parent 6c40122 commit 996a82e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ FROM mcr.microsoft.com/azure-functions/python:4-python3.9-core-tools
COPY library-scripts/*.sh library-scripts/*.env /tmp/library-scripts/

# Install Node.js, Azure Static Web Apps CLI and Azure Functions Core Tools
ARG NODE_VERSION="16"
ARG NODE_VERSION="18"
ARG NPM_VERSION="10"
ARG CORE_TOOLS_VERSION="4"
ARG USERNAME="swa-cli"
ARG SWA_CLI_VERSION
Expand All @@ -27,7 +28,7 @@ RUN bash /tmp/library-scripts/node-debian.sh "${NVM_DIR}" "${NODE_VERSION}" "${U
&& if [ $CORE_TOOLS_VERSION != "4" ]; then apt-get remove -y azure-functions-core-tools-4 && apt-get install -y "azure-functions-core-tools-${CORE_TOOLS_VERSION}"; fi \
&& apt-get clean -y && rm -rf /var/lib/apt/lists/*

RUN su swa-cli -c "umask 0002 && npm install --cache /tmp/empty-cache -g npm@latest fuzz-run" \
RUN su swa-cli -c "umask 0002 && npm install --cache /tmp/empty-cache -g npm@$NPM_VERSION fuzz-run" \
&& if [ -n "$SWA_CLI_VERSION" ]; then su swa-cli -c "umask 0002 && npm install --cache /tmp/empty-cache -g @azure/static-web-apps-cli@$SWA_CLI_VERSION"; fi

USER swa-cli
Expand Down
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"args": {
// Please look at runtime version support to make sure you're using compatible versions
// https://docs.microsoft.com/en-us/azure/azure-functions/supported-languages#languages-by-runtime-version
"NODE_VERSION": "16",
"NODE_VERSION": "18",
"CORE_TOOLS_VERSION": "4"
}
},
Expand Down

0 comments on commit 996a82e

Please sign in to comment.