Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Error fetching Function Core Tools releases: Cannot find downloa… #900

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

rondonjon
Copy link
Contributor

…d package for Windows' (#899)

@github-actions github-actions bot added the scope: core Issues happened a the ./src/core level label Dec 13, 2024
@rondonjon
Copy link
Contributor Author

@microsoft-github-policy-service agree

@Timothyw0
Copy link
Member

Hi @rondonjon! Thank you for your contribution to our library and congratulations on your first pull request to the Azure SWA CLI 😄

Could you please confirm if this fix has solved the issue you raised on our page? You can test your local changes by running npm run build in your SWA CLI repo and then npm link ./ to create a symbolic link to your local SWA CLI build. Any subsequent runs using the SWA CLI on your machine should then use your latest changes.

Once you confirm that your changes do indeed fix the issue, I will merge this for our next release. Thank you again!

@Timothyw0
Copy link
Member

I tested this PR myself and can confirm that the Functions Core Tools is downloading properly with the new logic. Thank you for your contribution! I will get this merged in after some more housekeeping work is complete for the next release! 😄

Before logic change:
image

After logic change:
image

@Timothyw0 Timothyw0 merged commit 08ac5a1 into Azure:main Jan 7, 2025
9 of 15 checks passed
@Timothyw0 Timothyw0 mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: core Issues happened a the ./src/core level
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants